feat(core): loop suite, observability and memory P1 modules (split from #181) - #190
Open
raymondginger2018-sudo wants to merge 4 commits into
Open
feat(core): loop suite, observability and memory P1 modules (split from #181)#190raymondginger2018-sudo wants to merge 4 commits into
raymondginger2018-sudo wants to merge 4 commits into
Conversation
This was referenced Aug 22, 2026
Contributor
Author
|
CI status note for the wiring split of #181:
As noted in the description, this PR keeps the explicit no-op fallback for the |
HKUDS#181) P1 course modules that wire into existing behavior, kept together so the smaller independent PRs (#keyring, #classifier) can merge first: - observability/events.py: emit_event bus (used by P1-5 deposit event) - memory_distill.py: compaction summaries -> memory vault (P1-5) - loop/: optimizer/evaluation/retrieval_evaluation/cerebellum_optimizer/ goal_file/injection_regression/memory_retrieval (P1-6/7/8) - runner.py/session.py: compaction_summary_sink + tool-loop temperature default (P1-4/5) - memory.py: P1-3 data boundary around memory notes (framed + untrusted) - mcp/: server allowlist + description quality (P1-2/9) - agent_setup.py: system-prompt integrity clause 132 module tests + 17 memory regression tests pass; framing assertion test_every_injected_instruction_source_is_framed stays green.
raymondginger2018-sudo
force-pushed
the
pr181/loop
branch
from
August 25, 2026 07:02
ccaf44e to
72829f1
Compare
Contributor
Author
|
Hi Zongwei, this is the loop suite + observability + memory P1 modules split from #181. Wires into existing behavior but keeps an explicit no-op fallback for the observability import so it is safe regardless of merge order. Rebased onto latest main (e0767d0), all tests green (3.12/3.13/3.14). The lint failure is a pre-existing N999 issue on upstream main, not caused by this PR. Ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The wiring part of #181, split per maintainer review so the two independent modules (keyring, classifier) can merge first. Contains the P1 course modules that touch existing behavior, kept together because they share the compaction/observability path:
runner.pygainsAgentRunSpec.compaction_summary_sink+_notify_compaction_summary;session.pybuilds the sink that appends summaries to the memory vault (memory_distill.py) and fires thememory.compaction.depositedevent viaobservability/events.py._DEFAULT_TOOL_LOOP_TEMPERATURE = 0.1used only when the execution profile does not set one.memory.pywraps memory notes in a framed, explicitly-untrusted data block (injection_regression.render_data_block); the upstream framing assertiontest_every_injected_instruction_source_is_framedstays green.loop/goal_file.py,optimizer.py,evaluation.py,retrieval_evaluation.py,cerebellum_optimizer.py,injection_regression.py,memory_retrieval.py.mcp/naming.py+runtime.py) and tool description quality (tools/base.py+mcp/tools.py).Tests
test_every_injected_instruction_source_is_framedDependency note
session.pyimportscore.observability.events(this PR); it already contains an explicit no-op fallback so merge order vs. #183 is irrelevant.