Repository navigation
Conversation
Gugic
marked this pull request as ready for review
October 20, 2026 19:38
…rue-verification-hardening
Owner
Author
|
Moved to the organization-owned GHES fork: https://github.inworld.dev/inworld-ai/gotrue/pull/2. The refreshed e599e97 head passed all six GitHub.com checks after dependency PR #2 merged. Source history and this PR remain available for review context; continue review and merging on GHES. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Email-link credentials currently inherit the numeric OTP guessing space, and failed code guesses have no shared account budget. This separates the credentials and enforces verification limits in GoTrue.
Prerequisite: merge #2 first, then refresh this branch from
inworld/v2.197.0. Both PRs target the maintained branch independently. A temporary combined tree is conflict-free and passes the H1 security and shared-attempt suites under Go 1.27.2 and the upgraded dependencies.The recovery-code functional suite uses a bounded test-only two-minute request deadline: Argon2 under race/coverage exceeded the production ten-second deadline while testing lockout state transitions.
Targets the maintained
inworld/v2.197.0branch as explicitly requested. This PR changes source only. Rollout needs a new fork tag/image and separate deployment PRs. Existing credentials retain their original expiry. During a mixed-version rollout or rollback, older binaries can redeem the new links but cannot redeem newly issued numeric codes. Full containment requires all replicas updated and legacy low-entropy links expired.Verified:
make testpassed with Go 1.27.0, race detection, repository-wide coverage and the required coverage gate, including all six new security regression tests.make lintreports 13 vulnerabilities also reproduced on its unchanged base. The separate prerequisite PR fix(deps): patch Go dependencies and restore fork CI #2 clears them and the Go 1.27.2 Staticcheck compatibility issue.Not verified: