Repository navigation
docs: document GUAKE_ENABLE_WAYLAND in the FAQ - #2362
Open
shaktimaan00 wants to merge 1 commit into
Open
shaktimaan00 wants to merge 1 commit into
shaktimaan00 wants to merge 1 commit into
Conversation
The FAQ only talks about the manual keybinding workaround, nothing explains the GUAKE_ENABLE_WAYLAND switch itself. Spell out that Guake defaults to the X11 GDK backend, that presence of the variable (not its value) is what counts, where to put it so the instance started at login sees it, and what it means for the show/hide key. closes Guake#1976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Wayland note in the FAQ only covers the manual keybinding workaround. There is nothing that explains the GUAKE_ENABLE_WAYLAND switch at all, so people end up reading guake/main.py or guessing (see the last few comments on #1976).
I added a subsection under "Note on Wayland" covering:
Checked against the code paths in guake/main.py, guake/keybindings.py (empty/disabled values are skipped before binding) and guake/prefs.py. Docs build is clean: rst parsed and rendered without warnings. No code changed, so make check and make test are unaffected; the reno note is there for the changelog.
closes #1976