Skip to content

chore: ignore the local module overlay files - #343

Merged
Patel230 merged 1 commit into
mainfrom
chore/ignore-local-module-overlay
Sep 29, 2026
Merged

Patel230 merged 1 commit into
mainfrom
chore/ignore-local-module-overlay

Conversation

@Patel230

Copy link
Copy Markdown
Contributor

go.local.mod carries a replace directive pointing at ../flux so rho can
be tested against a local sibling checkout. It must never be committed: CI runs
with no overlay and builds against the pinned published module, and a committed
replace would silently override it.

The files showed as untracked in every checkout, so they were one git add .
away from being committed. rho's own contributor guidance describes this
overlay, but nothing enforced it.

No code change.

go.local.mod carries a `replace` directive pointing at a sibling checkout
so rho can be tested against local flux changes. It must never be committed:
CI runs with no overlay and builds against the pinned published module, and a
committed replace would silently override it. The files were showing as
untracked in every checkout.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Patel230
Patel230 merged commit b7823b2 into main Sep 29, 2026
21 checks passed
@Patel230
Patel230 deleted the chore/ignore-local-module-overlay branch September 29, 2026 17:07
Patel230 added a commit that referenced this pull request Oct 2, 2026
go.local.mod carries a `replace` directive pointing at a sibling checkout
so rho can be tested against local flux changes. It must never be committed:
CI runs with no overlay and builds against the pinned published module, and a
committed replace would silently override it. The files were showing as
untracked in every checkout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant