Repository navigation
fix(mcp): stop tsc class fields from wiping model instances in configure_environment - #279
Draft
vigneshrajsb wants to merge 1 commit into
Draft
vigneshrajsb wants to merge 1 commit into
vigneshrajsb wants to merge 1 commit into
Conversation
…ure_environment The server build emits declared model properties as class fields, so an Objection instance patched via $query().patch() was overwritten with undefined values. Disable useDefineForClassFields for the server build and log unexpected errors in the environment operation error mapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
configure_environmentreturnedinternal_errorfor any change to a service'sactiveorbranchOrExternalUrl.tscbuild ofws-server, wheretarget: esnextemits declared model properties (id!: number,deployableId, ...) as class fields. Objection'sinstance.$query().patch()then overwrote the instance withundefinedvalues, and the next read of the instance (d.deployable.dependsOnDeployableName) threw aTypeError. REST routes are built by Next/SWC and Jest by Babel, which don't emit those fields, so only MCP hit it.useDefineForClassFields: falseintsconfig.server.json.mapEnvironmentOperationErrorbefore mapping tointernal_error; the client message is unchanged.Verifying Changes
BuildService/OverrideService:active:falsethrough the MCP handler failed before and passes with the option off.activeandbranchOrExternalUrlpatches.eslint, prettier andjest src/server/mcp src/server/modelspass;tscshows only pre-existing errors.