Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The arm profile overwrites docker.runOptions, dropping the conditional Bambu volume mount and causing tasks to fail when the local package is outside Nextflow’s normal mounts.
1 open issue
What changed in this PR
Updates Bambu-Pipe to v0.10.4 with stricter input validation, simpler manual-clustering restarts, unified clustering, and revised resource settings for single-cell and spatial workflows.
Changes:
- Replaces restart samplesheets with explicit input flags and validates standard samplesheets before processing.
- Unifies Seurat clustering, corrects Harmony integration, and adds barcode-search, discovery, and clustering controls.
- Adjusts CPU allocation and retries, updates containers and documentation, and removes unused fusion-detection code.
| File | Description |
|---|---|
| subworkflows/prepare_input_standard.nf | Validates complete samplesheets before routing inputs. |
| subworkflows/clustering_standard.nf | Removes the separate clustering dispatcher. |
| subworkflows/alignment.nf | Clarifies the GTF-to-BED comment. |
| README.md | Documents revised parameters, restarts, outputs, and visualization. |
| nextflow.config | Updates release defaults, mounts, profiles, and report overwriting. |
| modules/seurat/visium_hd/clustering.nf | Renames the process and passes configurable dimensions. |
| modules/seurat/standard/single_sample_clustering.nf | Removes the separate single-sample process. |
| modules/seurat/standard/clustering.nf | Unifies clustering and applies Harmony to varying covariates. |
| modules/preprocess_fastq.nf | Adds optional full-rank barcode searching. |
| modules/prepare_input/visium_hd/spot_bin_mappings.nf | Uses a single CPU. |
| modules/prepare_input/visium_hd/convert_tissue_positions.nf | Uses a single CPU. |
| modules/prepare_input/visium_hd/convert_barcode_mappings.nf | Uses a single CPU. |
| modules/prepare_input/standard/visium_build_tissue_positions.nf | Uses a single CPU. |
| modules/prepare_input/shared/filter_barcoded_bam.nf | Always publishes filtered BAMs under bam/. |
| modules/bambu/visium_hd/transcript_discovery.nf | Sets discovery cores and the read-fraction threshold. |
| modules/bambu/visium_hd/spot_level_quantification.nf | Removes the unused genome input. |
| modules/bambu/visium_hd/map_clusters_to_2um_spots.nf | Uses a single CPU. |
| modules/bambu/visium_hd/extract_spot_barcodes.nf | Uses a single CPU. |
| modules/bambu/visium_hd/aggregate_bins.nf | Uses a single CPU. |
| modules/bambu/standard/transcript_discovery.nf | Sets discovery cores and the read-fraction threshold. |
| modules/bambu/standard/single_cell_quantification.nf | Removes the unused genome input. |
| modules/bambu/shared/prepare_annotation.nf | Uses a single CPU. |
| modules/bambu/shared/construct_read_class.nf | Limits concurrent tasks and uses Bambu’s default core count. |
| modules/bambu/shared/cluster_level_quantification.nf | Removes the unused genome input. |
| modules/alignment/gff2bed.nf | Uses a single CPU. |
| main.nf | Separates restart workflows and wires revised parameters and processes. |
| lib/Validation.groovy | Validates restart inputs, parameter ranges, and complete samplesheets. |
| jaffal/tools.groovy | Removes unused JAFFAL tool settings. |
| jaffal/scripts/get_fusion_seqs.bash | Removes the unused fusion-sequence helper. |
| jaffal/scripts/get_cell_barcodes_by_fusion.bash | Removes the unused fusion-barcode helper. |
| jaffal/make_final_table.R | Removes unused fusion-result processing. |
| jaffal/JAFFAL.groovy | Removes the unused JAFFAL pipeline. |
| jaffal/JAFFA_stages.groovy | Removes unused JAFFA stages. |
| jaffal/get_spanning_reads.R | Removes unused spanning-read calculations. |
| jaffal/compile_results.R | Removes unused fusion-result compilation. |
| examples/samplesheet_visium_hd_quant_data.csv | Removes the obsolete spatial restart samplesheet. |
| examples/samplesheet_test_sc_quant_data.csv | Removes the obsolete single-cell restart samplesheet. |
| containers/seurat/Dockerfile | Pins R packages and revises build dependencies. |
| conf/smoke_test.config | Migrates restart profiles to explicit input flags. |
| conf/dev.config | Adds resource and seed settings; removes obsolete options. |
| conf/containers.config | Updates the Seurat container tag. |
| conf/base.config | Fixes CPU allocations and revises retry limits. |
| CHANGELOG.md | Records v0.10.4 features, fixes, and breaking changes. |
| bin/visium_hd_cluster.R | Accepts explicit clustering dimensions. |
| bin/JAFFAL.groovy | Removes the unused fusion pipeline entry point. |
| bin/fusion_detection.R | Removes the unused fusion-detection script. |
| bin/fusion_detection_functions.R | Removes unused fusion-annotation helpers. |
| bin/bambu_discovery_to_unique_counts.R | Forwards discovery options to Bambu. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.