You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Mr444-dev Thanks for the docs. Please change these three things:
Remove DuckDBTimeNs. It's being removed from Data in feat(data): support writing TIME_NS values DuckDB.NET#387 (comment), so please take out the DuckDBTimeNs row in mapped-appender.md, DuckDBTimeNs in the TIME_NS row of type-mapping.md, and "while DuckDBTimeNs exposes the stored nanoseconds" in the precision note.
Drop the TimeSpan parameter note. It doesn't match what the converter does:
With a plain SELECT ?, DuckDB doesn't know the parameter's type, so a TimeSpan with DbType.Time goes through ValueCreators[DbType.Time] and arrives as a microsecond TIME. The ticks are not kept.
When DuckDB knows the parameter is TIME_NS (an INSERT into a TIME_NS column, or ?::TIME_NS), the (DuckDBType.TimeNs, TimeSpan) case keeps the ticks, with or without DbType.Time.
This page is also about reading ("when reading data with GetValue and GetFieldValue"), and TIME has the same DbType.Time rule without a note. Parameters for TIME and TIME_NS can be documented together later on a page of their own.
Add > [!NOTE] to the precision note. The other notes on the page start with it; without it the note renders as a plain blockquote.
Hi Giorgi, I’ve updated the documentation in commit c466102:
Removed DuckDBTimeNs from the mapped-appender table, the TIME_NS type mapping, and the precision note.
Removed the TimeSpan command-parameter note.
Changed the precision blockquote to a DocFX [!NOTE].
git diff --check passes. The DocFX CLI is not installed in my local environment, so I could not build the site locally. The related library PR #387 has now been merged. Could you please review the update?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeOnlyandDuckDBTimeOnlymapped-appender support for TIME_NS columns.Validation
git diff --checkpassed.