Repository navigation
refactor(MessageList): render thread messages from the thread unread snapshot - #3324
Merged
oliverlaz merged 1 commit intoOct 16, 2026
Merged
Conversation
…snapshot useMessageListElements read the unread snapshot from channel.messagePaginator even inside a thread, while the rest of MessageList reads it from the rendered list via useMessagePaginator(). A thread list re-rendered on every change to the channel snapshot, and a custom renderMessages received the channel state.
NikolaGoranNaumovski
requested review from
MartinCupela and
oliverlaz
as code owners
October 14, 2026 10:40
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: rendering thread messages from the thread unread snapshot. |
| Description check | |
The description includes the required Goal, Implementation details, and UI Changes sections. It explains the problem, implementation, behavior change, test coverage, and validation results. It correct… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
Size Change: +20 B (0%) Total Size: 884 kB 📦 View Changed
ℹ️ View Unchanged
|
MartinCupela
approved these changes
Oct 14, 2026
Contributor
|
I would commit it as a fix |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3324 +/- ##
==========================================
+ Coverage 86.58% 86.63% +0.05%
==========================================
Files 546 546
Lines 16214 16215 +1
Branches 5087 5087
==========================================
+ Hits 14039 14048 +9
+ Misses 2175 2167 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oliverlaz
approved these changes
Oct 16, 2026
oliverlaz
deleted the
refactor/message-list-elements-thread-unread-snapshot
branch
October 16, 2026 09:56
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Inside a thread,
MessageListreads its unread state from the thread's message paginator (useMessagePaginator()): the unread banner, the "N new" notification anduseMarkReadall use the thread'sunreadStateSnapshot.useMessageListElementswas the exception. It always subscribed tochannel.messagePaginator.unreadStateSnapshot, even when the list rendered a thread.As a result:
renderMessageson every change to the channel's unread snapshot (e.g. a new channel message arriving while the channel is scrolled up), although nothing in the thread changed;renderMessagesused in a thread received the channel's unread state inchannelUnreadUiStateinstead of the thread's.No unread separator rendered incorrectly:
getIsFirstUnreadMessagealready returnsfalsefor thread replies (they carry aparent_id), so the default UI looked the same either way.🛠 Implementation details
useMessageListElementsnow subscribes touseMessagePaginator().unreadStateSnapshot, which resolves to the thread's paginator inside a thread and the channel's otherwise. This matches howMessageList,useUnreadMessagesNotificationanduseMarkReadalready resolve it. Outside a thread nothing changes.Behavior note for integrators: a custom
renderMessagesrendered inside a thread now receives the thread's unread snapshot inchannelUnreadUiState. The parameter name is unchanged.Test added in
MessageList.test.tsx, using a real thread fromclient.threads.ensure()(the existing thread stub shares the channel's paginator, so it could not tell the two apart):renderMessages;It fails without the change and passes with it. The MessageList, Thread and Threads suites pass, and
yarn lint/yarn typesare clean.🎨 UI Changes
None. The change affects which store the thread's message list subscribes to, not what it renders.
Summary by CodeRabbit