feat: support skip_truncate on channel delete - #173
Merged
Conversation
Soft deleting a channel truncates it, so a channel recreated with the same ID comes back empty. Channel::delete now forwards query params, which lets callers pass skip_truncate. Client::deleteChannels already forwards options, so the batch endpoint needs no change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
yaziine
approved these changes
Sep 10, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CHA-5241
Problem
Soft deleting a channel also truncates it, so a channel recreated with the same ID comes back empty and replies quoting older messages fail. The API gained a
skip_truncateoption that keeps the history, andChannel::delete()takes no arguments, so it cannot be sent.Solution
Channel::delete()takes an optional options array and forwards it as query params, so["skip_truncate" => true]reaches the endpoint. Existing calls pass an empty array, unchanged.Client::deleteChannels()already forwards arbitrary options into the request body, so the batch endpoint needed no code change, only a docs example.The server owns the rules:
skip_truncateis rejected together with a hard delete, and only distinct channels are eligible.How to verify
vendor/bin/phpunit --testsuite "Unit Test Suite" --filter ChannelDeleteTestpasses. The two tests assert the options array reaches the client and defaults to empty.vendor/bin/php-cs-fixer fix --dry-run --diffreports no changes.🤖 Generated with Claude Code