Skip to content

fix(Intersections): robustness and performance of the intersections inspection #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BotellaA merged 15 commits into from
Oct 15, 2026
Merged

fix(Intersections): robustness and performance of the intersections inspection #201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3961df1
fix(Intersections): use mesh1 index for Section shared edge vertex
BotellaA Oct 14, 2026
275a391
fix(Intersections): never match vertices without unique vertex
BotellaA Oct 14, 2026
1ed8820
fix(Intersections): an empty component mesh no longer disables the in…
BotellaA Oct 14, 2026
c0dc862
fix(Intersections): Section triangles nested in another are detected
BotellaA Oct 14, 2026
03da6f9
fix(Intersections): detect lines crossing a surface in its plane
BotellaA Oct 14, 2026
cf5e731
fix(Intersections): detect overlapping collinear line edges
BotellaA Oct 14, 2026
d4a3551
fix(Intersections): common vertices use the same point in both triangles
BotellaA Oct 14, 2026
2b52c53
perf(Intersections): precompute the unique vertices of surface meshes
BotellaA Oct 14, 2026
2c37c68
perf(Intersections): reject 3D triangle pairs separated by a plane
BotellaA Oct 14, 2026
8f27752
perf(Intersections): self intersections skip pairs of different surfaces
BotellaA Oct 14, 2026
e3f772e
perf(Intersections): cull and parallelize line/surface checks
BotellaA Oct 14, 2026
b1b4d8a
perf(Intersections): remove redundant point positions in surface/curv…
BotellaA Oct 14, 2026
86b5eee
perf(Intersections): no heap allocation for quad fan triangles
BotellaA Oct 14, 2026
0a2aa93
test(Intersections): straight line with collinear edges, explain nest…
BotellaA Oct 15, 2026
d22f455
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeode-I…
BotellaA Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bindings/python/tests/inspection/test-py-brep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ def check_a1(verbose):
nb_component_meshes_issues = launch_component_meshes_validity_checks(
result.meshes, verbose
)
if nb_component_meshes_issues != 13494:
if nb_component_meshes_issues != 14748:
raise ValueError(
"[Test] model model_A1_valid should have 13494 component meshes issues (pairs of component meshes triangles intersecting)."
"[Test] model model_A1_valid should have 14748 component meshes issues (pairs of component meshes triangles intersecting)."
)


Expand All @@ -249,9 +249,9 @@ def inspect_model_A1(model_brep, verbose):
nb_component_meshes_issues = launch_component_meshes_validity_checks(
result.meshes, verbose
)
if nb_component_meshes_issues != 13494:
if nb_component_meshes_issues != 14748:
raise ValueError(
"[Test] model model_A1_valid should have 13494 component meshes issues (pairs of component meshes triangles intersecting)."
"[Test] model model_A1_valid should have 14748 component meshes issues (pairs of component meshes triangles intersecting)."
)


Expand Down
Loading
Loading