Skip to content

Figure.solar: Improve docstrings and add type hints for terminator_datetime - #4915

Draft
seisman wants to merge 2 commits into
mainfrom
doc/solar
Draft

seisman wants to merge 2 commits into
mainfrom
doc/solar

Conversation

@seisman

@seisman seisman commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Changes in this PR:

  • Add one extra inline example showing the simplest Figure.solar usage
  • Remove unnecessary comments from the inline example
  • Add type hints for the terminator_datetime parameter

Preview: https://pygmt-dev--4915.org.readthedocs.build/en/4915/api/generated/pygmt.Figure.solar.html#pygmt.Figure.solar

Waiting for #4916 first.

@seisman seisman added this to the 0.20.0 milestone Sep 23, 2026
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer labels Sep 23, 2026
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Sep 24, 2026
@seisman
seisman marked this pull request as draft September 24, 2026 03:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant