trend1d: make parameter output of same type as second output column (#9226) - #9227
Merged
Merged
Conversation
joa-quim
approved these changes
Sep 24, 2026
Contributor
Author
|
I realised that the solution would be better when the type of the second output column is used. Thus the user keeps control of the output type that could be different from the input type. This is now in commit d45adac. |
remkos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This makes sure that the parameters that are output by
trend1d -Fpare of the same type as the second input column. Otherwise first parameter could be, for example, absolute time.Fixes #9226