Repository navigation
fix(lapis): render empty Or and And as valid SaneQL - #1925
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fengelniederhammer
approved these changes
Oct 21, 2026
A filter by an empty list, e.g. `{"accession": []}`, maps to an Or without
children, which rendered as `filter(())` and failed with a parse error.
Render an empty Or as `false` and an empty And as `true`.
taepper
force-pushed
the
fix-empty-and-or
branch
from
October 21, 2026 12:32
0d32a76 to
8ee5d59
Compare
fengelniederhammer
pushed a commit
that referenced
this pull request
Oct 22, 2026
🤖 I have created a release *beep* *boop* --- ## [0.9.1](v0.9.0...v0.9.1) (2026-10-21) ### Bug Fixes * **lapis:** `isNull()` advanced queries now also produce `isNull` RhyDB queries ([#1918](#1918)) ([76beb2d](76beb2d)) * **lapis:** handle large arrow strings from RhyDB ([#1919](#1919)) ([ba73ea3](ba73ea3)) * **lapis:** render empty Or and And as valid SaneQL ([#1925](#1925)) ([7b15acb](7b15acb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1924
A filter by an empty list, e.g.
{"accession": []}, maps to an Or without children, which rendered asfilter(())and failed with a parse error. Render an empty Or asfalseand an empty And astrue.PR Checklist
llms.txt.