Repository navigation
fix(lapis): handle large arrow strings from RhyDB - #1919
Merged
Merged
Conversation
fengelniederhammer
requested review from
fhennig and
taepper
and
a balanced review from Copilot
October 20, 2026 16:35
fengelniederhammer
added this pull request to stack #1920
October 20, 2026 16:35
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the focused compatibility change; existing tests cover the updated fixtures but were not executed.
No open issues 🎉
What changed in this PR
Updates LAPIS to read RhyDB’s large Arrow string columns while retaining support for standard strings.
Changes:
- Supports
LargeVarCharVectorin string and JSON conversion. - Updates test fixtures to emit
LargeUtf8columns.
| File | Description |
|---|---|
lapis/src/test/kotlin/org/genspectrum/lapis/rhydb/ArrowTestHelper.kt |
Generates large-string Arrow fixtures for existing tests. |
lapis/src/main/kotlin/org/genspectrum/lapis/rhydb/ArrowRowConverter.kt |
Handles both large and standard Arrow strings. |
Review effort: Balanced
fhennig
approved these changes
Oct 21, 2026
fengelniederhammer
force-pushed
the
fixLargeString
branch
from
October 21, 2026 11:54
021a31f to
1c7ff64
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adapt LAPIS to changes of RhyOrg/RhyDB#1723
PR Checklist
llms.txt.