Repository navigation
fix(lapis): isNull() advanced queries now also produce isNull RhyDB queries - #1918
Merged
Merged
Conversation
…DB queries RhyOrg/RhyDB#1710 broke a test, since lineage queries don't accept `null` anymore
fengelniederhammer
requested review from
fhennig
and
a balanced review from Copilot
October 20, 2026 15:59
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports the consistent use of existing IsNull functionality with no unresolved issues; tests were not executed.
No open issues 🎉
What changed in this PR
Updates advanced-query null checks to use RhyDB’s dedicated IsNull expression, restoring compatibility with lineage queries that no longer accept null values.
Changes:
- Uses
IsNullconsistently across metadata types. - Makes equality-filter values non-nullable and updates tests.
- Documents LAPIS 0.9.1 compatibility with RhyDB 0.17.0.
| File | Description |
|---|---|
| README.md | Adds the compatibility entry. |
| lapis/src/test/kotlin/org/genspectrum/lapis/rhydb/RhyDbQueryToSaneQlTest.kt | Removes obsolete nullable-equality conversion cases. |
| lapis/src/test/kotlin/org/genspectrum/lapis/rhydb/RhyDbQueryTest.kt | Removes obsolete nullable-equality serialization cases. |
| lapis/src/test/kotlin/org/genspectrum/lapis/model/AdvancedQueryFacadeTest.kt | Updates null-check expectations to IsNull. |
| lapis/src/main/kotlin/org/genspectrum/lapis/rhydb/RhyDbQuery.kt | Requires non-null equality values and simplifies conversion. |
| lapis/src/main/kotlin/org/genspectrum/lapis/model/AdvancedQueryCustomListener.kt | Maps all advanced null checks to IsNull. |
Review effort: Balanced
fengelniederhammer
added this pull request to stack #1920
October 20, 2026 16:35
Contributor
|
@fengelniederhammer there is a failing test |
Contributor
Author
The next PR in the stack solves the issue (there were two breaking changes in RhyDB) |
fhennig
approved these changes
Oct 21, 2026
fengelniederhammer
pushed a commit
that referenced
this pull request
Oct 22, 2026
🤖 I have created a release *beep* *boop* --- ## [0.9.1](v0.9.0...v0.9.1) (2026-10-21) ### Bug Fixes * **lapis:** `isNull()` advanced queries now also produce `isNull` RhyDB queries ([#1918](#1918)) ([76beb2d](76beb2d)) * **lapis:** handle large arrow strings from RhyDB ([#1919](#1919)) ([ba73ea3](ba73ea3)) * **lapis:** render empty Or and And as valid SaneQL ([#1925](#1925)) ([7b15acb](7b15acb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RhyOrg/RhyDB#1710 broke a test, since lineage queries don't accept
nullanymorePR Checklist
llms.txt.