Repository navigation
chore(catalog): resync the vendored catalog so the drift check passes again - #307
Conversation
Desktop's copy of the service catalog had fallen nine files behind the web app, so the weekly drift check failed. The web catalog gained health signals for EarnApp, PacketStream and ProxyBase (a copy that looks healthy but earns nothing now shows as failing), marks device names and ids with `identifier`, records that Bitping has no referral programme, and declares each device_link's id shape. The id shape keys are new to Desktop's loader, and the strict-decode test refuses a vendored key the loader does not read, so DeviceLink now reads `id_shape` and `id_shape_unique`. The web app uses them to mask claimable device ids in text shown to anyone but the owner. Desktop has no such reader: its notices and logs show only in the owner's window, and the fleet API and pairing heartbeat carry slugs and status. The overlay README says so. Every referral link and code in the nine files is unchanged and correct. Fixes #306
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 77.46% 77.47% +0.01%
==========================================
Files 93 93
Lines 14539 14539
==========================================
+ Hits 11262 11264 +2
+ Misses 2333 2332 -1
+ Partials 944 943 -1
🚀 New features to boost your workflow:
|
|
Waiting on the macOS build only. On this head, GeiserX CI passed ubuntu, frontend and govulncheck, and the geiresx fork run passed windows, ubuntu, frontend and govulncheck (https://github.com/geiresx/CashPilot-Desktop/actions/runs/43956109016). The macOS job is still queued in both pools, and Windows is still queued here. CodeRabbit reviewed this head and found nothing. The referral links and codes of all nine changed services are correct. Merge once macOS goes green in either pool. |
Desktop's copy of the service catalog fell behind the web app. Nine files in
services/no longer matched the web catalog, so the weekly drift check failed.What changed in the web catalog
health_signals, includingunless,window_hoursandmin_matches. All the new patterns compile in Go.identifier. Desktop already reads it.program: false, because it has no referral programme. Desktop already reads it.device_link.id_shape, and EarnApp also setsid_shape_unique._schema.ymldocuments both keys.The fix
make catalog-synccopies the web files in. The overlay (digest pins and the Mysteriumnative:block) still applies.DeviceLinknow readsid_shapeandid_shape_unique. Without them the strict-decode test failed on this sync (field id_shape not found in type catalog.DeviceLink).catalog-overlay/README.mdrecords this under "Fields Desktop reads differently".Referral check
I compared the referral link and code of all nine changed services with our records. Each one is correct and unchanged. Bitping has no referral programme, so it keeps its plain signup link.
Checks
go run ./cmd/catalogsync -check -ref main: services matches GeiserX/CashPilot@main (54 files).go vet ./...: clean.go testpasses forinternal/catalog,internal/catalogsync,internal/healthandinternal/services, and for the root package's referral, README and rating tests.Fixes #306
Summary by CodeRabbit
New Features
Documentation