Repository navigation
test(import): catch a break in the unticked no-deploy row or the summed 64 KiB file limit - #304
Conversation
…he 64 KiB limit sums all files The importer already refuses both cases, but the render checks did not prove it, so a change could break either and CI would stay green. Add a not_deployable row marked selected to the preview fixture and check it renders with no tick. Add two files of 32 KiB + 1 byte each: one alone passes, both together are refused. Each new check fails against the matching mutation (rowSelectable without the not_deployable test, or the size checked per file instead of summed). Fixes #251
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…pair check that follows reads right The control file is 32 KiB plus one byte. Calling it just under half made the next check, which expects two of them to be refused, look wrong, and invited a size change that would break it.
Problem
The import page already handles two cases correctly, but no check proves it. A row with nothing to deploy must have no tick. Two files that are each under 64 KiB, but over it together, must be refused. A change could break either one and CI would stay green.
Fix
This adds two cases to
frontend/scripts/importer_check.mjs. It changes no app code.not_deployablerow that is marked selected. The check asserts the row renders with no tick and still shows its reason.Proof
Each new check fails against the matching mutation in
frontend/src/render/importer.ts:not_deployabledropped fromrowSelectable:FAIL a row with nothing to deploy has no tick, even when marked selectedFAIL two files over 64 KiB together are refused, though each is under itWith the code restored,
npx tsc --noEmitandnpm testpass (importer_check: 28 checks passed).Fixes #251
Summary by CodeRabbit