Skip to content

fix(hotfix): 抽方法降 TradeComponentAgent.OnPlaceAsync 认知复杂度 - #539

Merged
AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-9819-20261010T1230
Oct 10, 2026
Merged

AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-9819-20261010T1230

Conversation

@AlianBlank

Copy link
Copy Markdown
Collaborator

Linear: GFX-887

消除 Sonar csharpsquid:S3776(CRITICAL):OnPlaceAsync 认知复杂度
16 超过阈值 15。将撮合后的逐笔成交落账 foreach 循环抽成私有
helper RecordDeals(回执追加 + 流水落库 + 对手单全额成交摘除),
主方法降为 9、helper 为 7;循环体逐语句搬移,签名与运行时行为
零变更,现有测试零修改全通过。

Linear: GFX-887
@coderabbitai

coderabbitai Bot commented Oct 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0a9bc1e8-3c8c-4587-82f5-1bb053a1d0bd

📥 Commits

Reviewing files that changed from the base of the PR and between 3cab86a and 485c878.


📒 Files selected for processing (1)
  • GameFrameX.Hotfix/Logic/ServerRole/Trade/TradeComponentAgent.cs

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@AlianBlank
AlianBlank merged commit e1c4e63 into main Oct 10, 2026
3 checks passed
@AlianBlank
AlianBlank deleted the feature/auto-server-source-worker-run-9819-20261010T1230 branch October 10, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant