Repository navigation
fix(hotfix): 抽方法降 BattleRules.Simulate 认知复杂度 - #538
Conversation
消除 Sonar S3776（AaElsTY1oSiIXNEp0lag）：Simulate 认知复杂度 23 超阈值 15。 沿用主方法 + 私有 helper 约定（C141/C142/C181）：单回合战力求解（平局重掷 与护栏奇偶交替）抽为 ResolveRoundPower，rolls 取数兜底抽为 NextRoll， 拆分后 Simulate=4、helper=8/1；rolls 消费顺序、尝试计数、护栏语义与 回合记录零变更，现有 BattleRulesTests 全量通过。 Linear: GFX-886
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The refactor preserves the observed battle outcomes and is ready to merge after normal checks. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
标题准确概括了主要变更：通过提取方法降低 BattleRules.Simulate 的认知复杂度。标题具体、简洁，且与 PR 目标一致。 |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Linear: GFX-886
Summary by CodeRabbit