Skip to content

feat(ui): show propellant resource mix - #58

Merged
FennexFox merged 1 commit into
mainfrom
develop
Jul 12, 2026
Merged

FennexFox merged 1 commit into
mainfrom
develop

Conversation

@FennexFox

Copy link
Copy Markdown
Owner

What changed

  • Added a tooltip to display the propellant resource mix.
  • Introduced localization for propellant resource labels in English and Korean.

Why

  • Enhances user experience by providing detailed information about propellant resources.
  • Improves accessibility for users speaking different languages.

How

  • Implemented a new function to generate HTML for the propellant resources.
  • Updated existing tooltip components to include the new resource mix details.

Testing

  • Build / validation:
    • Ensure the application builds without errors.
  • Manual verification:
    • Check the tooltip for propellant resources in both English and Korean.
  • Generated files:
    • No generated files changed
    • docs/index.html regenerated
    • Catalog outputs regenerated
    • GitHub Pages workflow affected
  • If not tested, state why.

Risk / Rollback

  • Risk areas:
    • Potential issues with tooltip rendering or localization.
  • Rollback / mitigation:
    • Revert changes if tooltips do not display correctly.

Reviewer Checklist

  • Linked issue, investigation, or release item when applicable
  • README or docs updated if behavior or defaults changed
  • Generated output and deployment impact called out
  • Verification steps are specific enough to reproduce
  • Risk and rollback are concrete for shipped behavior

PR Classification (optional)

  • Feature
  • Bugfix
  • Refactor
  • Docs
  • Chore/Maintenance
  • Build/CI
  • Test

Justification:

Copilot AI review requested due to automatic review settings July 12, 2026 04:18
@FennexFox FennexFox self-assigned this Jul 12, 2026
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@FennexFox, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d3f257a5-fdf6-4201-98df-9e69165ae4cc

📥 Commits

Reviewing files that changed from the base of the PR and between b25c672 and 3bc1f41.

📒 Files selected for processing (5)
  • docs/assets/js/ui/tooltip_table.js
  • docs/index.html
  • tools/drive_comparison_client/ui/tooltip_table.js
  • tools/drive_comparison_styles.css
  • tools/verify_drive_comparison_browser.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@FennexFox
FennexFox merged commit 0a5a929 into main Jul 12, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds propellant “resource mix” details to the drive tooltip breakdown (with English/Korean labels) and extends the Playwright-based browser verification to assert the new UI behavior.

Changes:

  • Render a new “Resource mix / 자원 구성” <details> block in the tooltip mass breakdown, showing per-resource requirements in decatons.
  • Add tooltip CSS styles for the new resource grid and summary label.
  • Expand verify_drive_comparison_browser.mjs to validate presence, ordering, default-open state, units, and EN/KO labels (including a fallback fixture).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/drive_comparison_client/ui/tooltip_table.js Adds resource-mix HTML generation and EN/KO labels for propellant resources inside the tooltip breakdown.
tools/drive_comparison_styles.css Styles the new tooltip resource-mix <details> and grid layout.
tools/verify_drive_comparison_browser.mjs Adds automated browser verification for the new resource-mix tooltip content, including localization checks.
docs/index.html Regenerated published page output reflecting new tooltip styles (generated artifact).
docs/assets/js/ui/tooltip_table.js Regenerated published JS bundle reflecting tooltip changes (generated artifact).

Comment on lines +422 to +446
const items = Object.entries(materials)
.map(([key, coefficient]) => {
const amount = propellantTons * Number(coefficient) / 10;
if (!Number.isFinite(amount) || amount <= 0) return null;
return {
key,
label: propellantResourceLabel(key),
amount,
};
})
.filter(Boolean);
if (!items.length) {
const propellant = String(row && row.propellant || "").trim();
if (!propellant || propellant.toLowerCase() === "anything") return "";
return `
<details class="tooltip-propellant-resources muted" open>
<summary>${escapeHtml(UI_LANG === "en" ? "Resource mix" : "자원 구성")}</summary>
<div class="tooltip-propellant-resource-grid">
<span>${escapeHtml(propellant)}</span><strong>-</strong>
</div>
</details>
`;
}
const itemRows = items
.map(item => `<span>${escapeHtml(item.label)}</span><strong>${formatNumber(item.amount, UI_LANG === "en" ? " decatons" : " 데카톤")}</strong>`)
Comment thread docs/index.html
Comment on lines +2548 to +2552
.tooltip-propellant-resources {
margin: 0 0 7px;
overflow-wrap: anywhere;
}
.tooltip-propellant-resources summary {
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants