Repository navigation
Storage overflow: log why a host has to wait - #2108
Merged
Merged
Conversation
When a host PXE boots onto a node over its Max Clients and no other node in the group can take it, the host stays and waits in the queue. That left no trace of why: a full group, a disabled node, an unreachable node and a node that failed the host all looked the same (forums 18310). getOverflowNode() now writes one line to the web server's error log in that case. It names the node, its task count and Max Clients, the host and the group, and each node passed over with the reason. A host that moves, or fits, writes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
loadEnablednodes() drops a disabled node and one with Max Clients 0, so the loop never saw them and the log could not name them. Those are the settings most likely to be wrong, so list every node in allnodes that is missing from enablednodes. The test stub now builds enablednodes the same way, so it can no longer prove the reason on input production never has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Forums 18310: on 1.6.0.181, 12 hosts deployed to a 3-node group with Max Clients 10. Ten ran on the master. Two waited in the queue instead of moving to the two free nodes. The poster checked the node settings, the location settings, and that the main server reaches every node on 22, 443 and 80. My lab, on the same code, spreads the hosts every time.
StorageGroup::getOverflowNode()picks the node at PXE boot. When no node qualifies, the host stays and waits, and nothing records why. A full group, a disabled node, an unreachable node and a node that failed the host all look the same.Change
When a host is over its node's Max Clients and no other node can take it,
getOverflowNode()writes one line to the web server's error log:enablednodesalready leaves out disabled nodes and nodes with Max Clients 0, so the line lists those fromallnodes.error_log()unconditionally, like_fallbackNode(), so it does not depend on a logging setting.Tests
tests/optimal-node-balances-load.test.phpgains five cases: each skip reason, Max Clients 0, a full node, a one-node group, and no line for a host that moves or fits. The stub now buildsenablednodesthe wayloadEnablednodes()does. The new cases fail ondev-branch.🤖 Generated with Claude Code