Skip to content

Add the FOG 1.6 Activity page and the activity.view permission - #210

Merged
fog-workflows[bot] merged 1 commit into
masterfrom
feat/activity-page
Nov 17, 2026
Merged

fog-workflows[bot] merged 1 commit into
masterfrom
feat/activity-page

Conversation

@mastacontrola

Copy link
Copy Markdown
Member

Closes #206. Map: #155.

What

  • GET /activity and POST /api/v1/activity/datatable: a read-only Activity page under Logging, as FOG 1.6. It is a view over the audit trail, not a new table.
  • Rows: allowed writes that name their record (access.* with a subjectType), plus renderable events (agent rows). Denials, failures, sign-ins and sign-outs stay on the Audit Log page.
  • Each row has a plain-words summary, built at read time: Updated host "PC-01", Deleted image (3 records), Agent token, agentenrolltoken "lab": minted, 3 use(s).
  • New permission stock.activity.view (approved by Tom, 2026-11-17). It matches no model, so the generic :model routes stay closed (a test pins the 403).
  • 500-row cap, no "All", newest first. The Audit Log endpoint now shares the paging, search and order helper (api/helpers/audit/datatable.js); its behavior is unchanged.

Known gap

Some successful writes record no subject today (role assign and unassign, password and api-token resets, pending approve and delete, image scan and capture, account preferences, wol). They stay on the Audit Log page only. Follow-up on #155.

Tests

  • npm test: 559 passing. npm run test:ui and npm run test:ui:prod: all checks pass.
  • New: test/integration/activity-page.test.js, test/helpers/audit-summary.test.js, tools/smoke/checks/activity.js, and a Logging-children assertion in ui16-04-sidebar.js. Each fails without the change (the UI checks were run red with the menu entry removed).

Review

Built by an executor (Sonnet). Spec and standards reviews on Opus: three rounds, last verdicts CLEAN and one comment fix (applied).

🤖 Generated with Claude Code

Adds GET /activity and POST /api/v1/activity/datatable, a read-only view
over the audit trail (1.6 ActivityManagement, ADR 0023 "activity is a
view"). A row shows when a write succeeded and named its record, or when
the event marks itself renderable (the agent events). Each row carries a
plain-words summary built at read time (api/helpers/audit/summary.js).

- New permission stock.activity.view (Tom approved 2026-11-17). The key
  matches no model, so it opens no generic /api/v1/:model route.
- 500-row cap and no "All", as the Audit Log page.
- The Audit Log and Activity endpoints share the paging, search and
  order in api/helpers/audit/datatable.js.
- Activity sits before Audit Log in the Logging group; the sidebar smoke
  check now pins the Logging children.

Closes #206

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@fog-workflows
fog-workflows Bot enabled auto-merge November 17, 2026 17:48
@fog-workflows
fog-workflows Bot added this pull request to the merge queue Nov 17, 2026
Merged via the queue into master with commit 109d4ce Nov 17, 2026
10 of 11 checks passed
@fog-workflows
fog-workflows Bot deleted the feat/activity-page branch November 17, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the FOG 1.6 Activity page and the activity.view permission

1 participant