Repository navigation
Use https:// when the agent is given an http:// server address - #49
Merged
Merged
Conversation
The server knows an agent only by its TLS client certificate, so no call after enrollment works over plain HTTP. An agent installed with an http:// address enrolled, got a certificate it could never present, and failed every poll (forum topic 18320). A FOG install serves HTTPS whether or not it redirects HTTP to it. - enroll.HTTPSAddress moves http:// with no port or port 80 to https:// on the same host. Another port is kept and still fails, with the reason in the log. - Applied to --server (setup, enroll, run), to a config.json that holds http:// (enroll.Load), and to the `ca probe` wizard address. - The move is logged once per process, with userinfo redacted, and saved to config.json. The enrollment, key and host id are kept. - A machine whose polls are already refused cannot self-update to this release; it needs the MSI run again by hand. - protocol-v1.md, 0002-trust-model.md and install-windows.md say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server identifies an agent only by its TLS client certificate. Over plain HTTP the certificate never reaches the server. An agent installed with an
http://address enrolled, then failed every poll withserver refused this certificate(forum topic 18320). A FOG install serves HTTPS whether or not it redirects HTTP (installfog.sh --no-force-https: "serve both HTTP and HTTPS").Change
internal/enroll/serverurl.go:HTTPSAddressmoveshttp://with no port or port 80 tohttps://on the same host. Other ports are kept and still fail, with the reason logged (Name an http:// server and the server's 401 reason in the log #48).--server(openState,forgetStaleTrust), atenroll.Loadfor an existingconfig.json, and inProbeCA.repairConfiglogs the move once per process (userinfo redacted) and saves it. Enrollment, key and host id are kept.protocol-v1.md,0002-trust-model.md,install-windows.md.Limit
A machine whose polls are already refused gets no self-update, because the update arrives in the poll (
cmd/fog-agent/main.go,desired.Update). Those machines need the MSI run again by hand. After that, anhttp://address works.Verified
http://config.json (moved, host id kept, saved, not moved twice), setup with the flag, config and flag bothhttp://(one log line), and password redaction. Each fails with the move or the dedup turned off.🤖 Generated with Claude Code