Repository navigation
Trust re-check: correct the design text and tidy the tests - #40
Merged
Merged
Conversation
Design 0002 said a failed re-settle stops with an error and restores the old server URL. That holds only with --ca or a fingerprint. Without them setup continues with the old trust and saves --server, as before the check. The accepted-cost text now follows each code path, and the paragraph uses one term, "settle trust again". The restore error is wrapped as "restoring the old trust" inside the join. The duplicate fingerprint test is folded into the one that also checks the server URL, and its "(h)" comment sits on it again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #39, from its late review.
docs/design/0002-trust-model.md: the text said a failed re-settle stops with an error and restores the old server URL. That holds only with--caor a fingerprint. Without them, setup continues with the old trust and saves--server, as before the check. The accepted-cost text now follows each code path. Sentences are 20 words or fewer, with one term: "settle trust again".settleTrust: the restore error is wrapped as "restoring the old trust" insideerrors.Join.No behavior change.
🤖 Generated with Claude Code