Skip to content

Trust re-check: correct the design text and tidy the tests - #40

Merged
mastacontrola merged 1 commit into
mainfrom
fix/trust-doc-followups
Nov 6, 2026
Merged

mastacontrola merged 1 commit into
mainfrom
fix/trust-doc-followups

Conversation

@mastacontrola

Copy link
Copy Markdown
Member

Follow-up to #39, from its late review.

  • docs/design/0002-trust-model.md: the text said a failed re-settle stops with an error and restores the old server URL. That holds only with --ca or a fingerprint. Without them, setup continues with the old trust and saves --server, as before the check. The accepted-cost text now follows each code path. Sentences are 20 words or fewer, with one term: "settle trust again".
  • settleTrust: the restore error is wrapped as "restoring the old trust" inside errors.Join.
  • Tests: the duplicate fingerprint test is folded into the one that also checks the server URL. Its "(h)" comment sits on it again.

No behavior change.

🤖 Generated with Claude Code

Design 0002 said a failed re-settle stops with an error and restores the
old server URL. That holds only with --ca or a fingerprint. Without them
setup continues with the old trust and saves --server, as before the
check. The accepted-cost text now follows each code path, and the
paragraph uses one term, "settle trust again".

The restore error is wrapped as "restoring the old trust" inside the
join. The duplicate fingerprint test is folded into the one that also
checks the server URL, and its "(h)" comment sits on it again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mastacontrola
mastacontrola merged commit 48efab4 into main Nov 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant