Skip to content

Remove dead Markdown Database Integration persistence policies - #3686

Merged
chubes4 merged 1 commit into
mainfrom
fix/issue-3685-data-machine
Oct 26, 2026
Merged

chubes4 merged 1 commit into
mainfrom
fix/issue-3685-data-machine

Conversation

@chubes4

@chubes4 chubes4 commented Oct 26, 2026

Copy link
Copy Markdown
Member

Fixes #3685

Root cause

Data Machine registered two filters that Markdown Database Integration no longer applies:

Change

Deleted both classes, their two smoke tests, and the two register() calls in AlwaysOnServiceProvider. The datamachine_action_scheduler_log_persistence_row_budget filter goes with them; nothing in Data Machine or its sibling plugins uses it.

Action Scheduler still prunes its own logs through its retention cleanup.

Verification

  • php -l passes on the changed file.
  • Grep shows no remaining references in inc/, tests/, data-machine-business, intelligence or a8c-intelligence.
  • End to end on a disposable copy of a live mdi-native site running this branch:
    • WordPress boots with neither class nor filter present.
    • A wp_datamachine_jobs insert succeeds (id 296207).
    • Action Scheduler tables read normally, and MDI doctor reports healthy.

AI assistance: implemented and verified by Claude (Claude Code, Franklin) for @chubes4: code removal, consumer search and end-to-end run.

CanonicalPersistencePolicy declared partition identities through markdown_db_table_persistence_policy and LogPersistencePolicy bounded Action Scheduler log snapshots through markdown_db_persistent_table_query. MDI no longer applies either filter: the write engine and SQLite mirror that read them are retired, and mdi-native folds legacy partitions into snapshots.
@chubes4
chubes4 merged commit c7b0c65 into main Oct 26, 2026
26 checks passed
@chubes4
chubes4 deleted the fix/issue-3685-data-machine branch October 26, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove CanonicalPersistencePolicy: MDI no longer reads markdown_db_table_persistence_policy

1 participant