Repository navigation
Remove dead Markdown Database Integration persistence policies - #3686
Merged
Merged
Conversation
CanonicalPersistencePolicy declared partition identities through markdown_db_table_persistence_policy and LogPersistencePolicy bounded Action Scheduler log snapshots through markdown_db_persistent_table_query. MDI no longer applies either filter: the write engine and SQLite mirror that read them are retired, and mdi-native folds legacy partitions into snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3685
Root cause
Data Machine registered two filters that Markdown Database Integration no longer applies:
CanonicalPersistencePolicydeclaredpartition_byidentities fordatamachine_jobsanddatamachine_logsthroughmarkdown_db_table_persistence_policy. The only consumer was MDI's canonical-persistence write engine, which was removed in Remove dead code left by the backend retirements Automattic/markdown-database-integration#456. mdi-native now folds the legacy partitions into ordinary snapshots (Fold legacy row-partitioned tables into snapshots Automattic/markdown-database-integration#459).LogPersistencePolicylimited the Action Scheduler log snapshot throughmarkdown_db_persistent_table_query. Only MDI's retired SQLite mirror applied that filter.git grepin MDI main finds no references.Change
Deleted both classes, their two smoke tests, and the two
register()calls inAlwaysOnServiceProvider. Thedatamachine_action_scheduler_log_persistence_row_budgetfilter goes with them; nothing in Data Machine or its sibling plugins uses it.Action Scheduler still prunes its own logs through its retention cleanup.
Verification
php -lpasses on the changed file.inc/,tests/, data-machine-business, intelligence or a8c-intelligence.wp_datamachine_jobsinsert succeeds (id 296207).AI assistance: implemented and verified by Claude (Claude Code, Franklin) for @chubes4: code removal, consumer search and end-to-end run.