Repository navigation
test: fix two smokes broken by combining the #3649 repair PRs - #3682
Merged
Merged
Conversation
Refs #3649. Co-Authored-By: Extra Chill Bot (AI) <bot@extrachill.com>
runtime-vocabulary now ignores untracked runner output (.homeboy-bin/, shard plans). composable-caller-containment treats zombie processes as exited so a non-reaping CI subreaper does not mask successful containment. Co-Authored-By: Extra Chill Bot (AI) <bot@extrachill.com>
chubes4
force-pushed
the
fix/smoke-integration-main
branch
from
October 26, 2026 00:53
420f179 to
1a80fa8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3649. This is the last step to a fully green smoke suite.
Once #3676–#3681 were merged together, 2 smokes failed on
main(63bbf5a). Each one had passed on its own branch.flow-formatter-loaded-settings-display: test: add missing WordPress stubs to shared smoke-wp-stubs #3677 added a filter-registryapply_filters()to the sharedsmoke-wp-stubs.php. That stopped this smoke's ownfunction_exists-guardedapply_filters()override from ever being defined. The smoke now registers its step types and handler settings withadd_filter()against the shared registry.runtime-vocabulary: test: repair email, queue, retention and docs contract smokes #3680 and test: make host-dependent smokes hermetic and resolve toolchain from Homeboy #3681 addedHOMEBOY_WORDPRESS_CORE_ROOT/HOMEBOY_EXTENSION_PATHtoolchain lookups toemail-multi-inbox-forwardandcli-global-options. That is the same test-harness use for whichphpunit-file-isolationis already allowlisted, so both files join that allowlist. This check was already failing onmainbefore test: derive bootstrap/runtime contract smokes from current service composition #3679 repaired it, so neither branch's gate saw the new mentions.Verification
On
mainwith this patch and the CI environment (HOMEBOY_EXTENSION_PATH,HOMEBOY_WORDPRESS_CORE_ROOT): 0 of 371 smokes fail. Both audits pass. phpcs counts in both changed files equalmain's.AI disclosure: Claude found and fixed these interaction failures directly, outside Homeboy, while integrating the #3649 repair PRs at Chris's direction.
Update: CI-only fixes (commit 1a80fa8)
CI turned up two more failures that only reproduce on the GitHub runner:
runtime-vocabularywas scanning untracked runner output (.homeboy-bin/homeboy,homeboy-test-*.json). It now skips untracked files outsidevendor/. Tracked violations still fail; I checked with a probe file.composable-caller-containment: on the runner, the dead compose process is reparented to a subreaper that never reaps it, andposix_kill( $pid, 0 )still succeeds on a zombie. The probe now reads/proc/<pid>/statand treatsZ/Xas exited. I reproduced the failure locally under a non-reapingPR_SET_CHILD_SUBREAPERparent; with the fix it passes there, and it still fails when the monitor is disabled.Shard 1 and shard 4 are green now. What's still failing predates this work and is tracked in #3683 (
job-artifact-hashableon PHP 8.2, plus 1 unnamed PHPUnit test that was already failing on #3669/#3681).