Skip to content

test: fix two smokes broken by combining the #3649 repair PRs - #3682

Merged
chubes4 merged 2 commits into
mainfrom
fix/smoke-integration-main
Oct 26, 2026
Merged

chubes4 merged 2 commits into
mainfrom
fix/smoke-integration-main

Conversation

@chubes4

@chubes4 chubes4 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Part of #3649. This is the last step to a fully green smoke suite.

Once #3676–#3681 were merged together, 2 smokes failed on main (63bbf5a). Each one had passed on its own branch.

Verification

On main with this patch and the CI environment (HOMEBOY_EXTENSION_PATH, HOMEBOY_WORDPRESS_CORE_ROOT): 0 of 371 smokes fail. Both audits pass. phpcs counts in both changed files equal main's.


AI disclosure: Claude found and fixed these interaction failures directly, outside Homeboy, while integrating the #3649 repair PRs at Chris's direction.

Update: CI-only fixes (commit 1a80fa8)

CI turned up two more failures that only reproduce on the GitHub runner:

  • runtime-vocabulary was scanning untracked runner output (.homeboy-bin/homeboy, homeboy-test-*.json). It now skips untracked files outside vendor/. Tracked violations still fail; I checked with a probe file.
  • composable-caller-containment: on the runner, the dead compose process is reparented to a subreaper that never reaps it, and posix_kill( $pid, 0 ) still succeeds on a zombie. The probe now reads /proc/<pid>/stat and treats Z/X as exited. I reproduced the failure locally under a non-reaping PR_SET_CHILD_SUBREAPER parent; with the fix it passes there, and it still fails when the monitor is disabled.

Shard 1 and shard 4 are green now. What's still failing predates this work and is tracked in #3683 (job-artifact-hashable on PHP 8.2, plus 1 unnamed PHPUnit test that was already failing on #3669/#3681).

homeboy-ci Bot and others added 2 commits October 26, 2026 00:51
Refs #3649.

Co-Authored-By: Extra Chill Bot (AI) <bot@extrachill.com>
runtime-vocabulary now ignores untracked runner output (.homeboy-bin/, shard plans). composable-caller-containment treats zombie processes as exited so a non-reaping CI subreaper does not mask successful containment.

Co-Authored-By: Extra Chill Bot (AI) <bot@extrachill.com>
@chubes4
chubes4 force-pushed the fix/smoke-integration-main branch from 420f179 to 1a80fa8 Compare October 26, 2026 00:53
@chubes4
chubes4 merged commit d24d281 into main Oct 26, 2026
22 of 26 checks passed
@chubes4
chubes4 deleted the fix/smoke-integration-main branch October 26, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant