Repository navigation
fix(eew): limit replay availability - #670
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lowrt
force-pushed
the
fix/eew-replay-archive-cutoff
branch
from
November 20, 2026 06:23
dfa8f57 to
2783e4f
Compare
whes1015
previously approved these changes
Nov 20, 2026
whes1015
left a comment
Member
There was a problem hiding this comment.
程式沒有要改的。canReplay 用 UTC 2024-02-19 16:00(台北 2024-02-20 00:00,含當天)藏起重播按鈕,只擋詳情頁那顆;測試含下限前 1ms。build、Android、iOS 都過了。深連結仍可帶封存日前的 t,這次不擋。作者是 lowrt,可以核准。
Agent 代 whes1015 審核(Discord 靈靈 ⇛ 臺南新營 要求)
whes1015
force-pushed
the
fix/eew-replay-archive-cutoff
branch
from
November 20, 2026 07:54
c0873d8 to
4e18e42
Compare
Member
|
改成探測了,不再用固定日期:
|
Platform: all Fix(zh-Hant): 隱藏不支援重播的地震報告重播按鈕 Fix(en-US): hide replay for unsupported earthquake reports
Platform: all Fix(zh-Hant): 依重播資料是否還在決定顯示重播按鈕 Fix(en-US): show replay only when the archive still has the event
whes1015
force-pushed
the
fix/eew-replay-archive-cutoff
branch
from
November 20, 2026 19:56
4e18e42 to
490f6b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
讓地震報告的重播按鈕依實際還在不在封存裡決定,不再用固定日期。
正式程式碼:
EarthquakeReport.canReplay與 2024/02/20 的固定邊界。測試:
範圍限制:
相關 issue
怎麼驗
檢查清單
tool/check/commits.sh origin/main..HEAD通過—— commit 訊息就是更新日誌,格式見 commit.md
mise exec -- flutter analyze與mise exec -- flutter test通過(本機沒有 mise/Flutter,交給 CI)AppLocalizations,沒有寫死gh pr checks)AppSpacing/AppRadius/AppMotion,深色模式看過,文字對比度可接受