feat: Lots of new useful features and fix by PUDGE133 · Pull Request #864 · ExMod-Team/EXILED

PUDGE133 · 2026-08-26T20:22:19Z

Description

Describe the changes

Several very useful extension methods.
Additional overloads of the Get method for Door.
Improving the Door.Get(GameObject) method
Implementation of new properties for Firearm
Created stubs for the Log class methods
Added several new teleportation methods for the Player
Implemented a new property Server.ReservedSlots
And also a few minor corrections in the code and in the documentation for methods and properties

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentations

Submission checklist

I have checked the project can be compiled
I have tested my changes and it worked as expected

Other

Still requires more testing

PUDGE133 · 2026-08-26T20:24:54Z

If you have any questions, you can write here or to me on Discord: scaletta2019

louis1706 · 2026-08-31T18:38:56Z

+        /// <summary>
+        /// Gets or sets a value indicating whether the magazine is attached from the weapon.
+        /// </summary>
+        public bool IsMagazineDeattached
+        {
+            get => !IsMagazineAttached;
+            set => IsMagazineAttached = !value;
+        }


This is useless

This is useless

If you think this section of code is useless, then let's think this code is useless too:

If you think this section of code is useless, then let's think this code is useless too:

It may be useless, but it is not beneficial to remove it because that would be a breaking change. There is also no reason to add new junk code.

If you think this section of code is useless, then let's think this code is useless too:

It may be useless, but it is not beneficial to remove it because that would be a breaking change. There is also no reason to add new junk code.

No, no, no... you've had enough of this "critical code." You shouldn't have added it and then been afraid to remove it. As long as these and similar properties exist in the code, the code I've submitted will comply with Exiled standards.

This is excellent code; it reduces the cognitive load when reading it in plugins. There is no problem with it.

louis1706 · 2026-08-31T18:40:44Z


-        /// <inheritdoc cref="Player.Count"/>
-        public static int PlayerCount => Player.Count;
+        /// <summary>
+        /// Gets the number of players excluding NPCs.
+        /// </summary>
+        public static int PlayerCount => Player.Dictionary.Values.Count(x => !x.IsNPC);


No please don't break all plugin that would use that

No please don't break all plugin that would use that

Okay, I'll change it back. However, I don't understand why this property originally included NPCs. It once took me quite a while to figure out what was causing the bug. The problem was that someone misnamed the property. You should have named it something that would make it clear it included NPCs as well. If necessary, I can change the documentation for this property.

louis1706 · 2026-08-31T18:41:25Z

+        {
+            if (gameObject != null)
+            {
+                // ParentDoor requires enabling "unsafe code"


Weird comment?

Weird comment?

I will remove this comment.

louis1706 · 2026-08-31T18:46:49Z

+            if (room.Type == RoomType.Surface)
+                return relativePos;


Surface is a functional room technically i only see the purpose of this for Unknown Room

Or if you do it with the surface let's do it to all non dynamic rooms (i prefer to only do it on null that would be unknown)

Surface and pocket

Surface is a functional room technically i only see the purpose of this for Unknown Room

Or if you do it with the surface let's do it to all non dynamic rooms (i prefer to only do it on null that would be unknown)

Surface and pocket

I don't understand what you didn't like about this code.

louis1706 · 2026-08-31T18:47:38Z

+        public static string ToHumanReadable(this TimeSpan timeSpan)
+        {
+            if (timeSpan.TotalHours < 1)
+                return timeSpan.ToString(@"mm\:ss");
+
+            if (timeSpan.TotalDays < 1)
+                return timeSpan.ToString(@"hh\:mm\:ss");
+
+            string daysPart = timeSpan.Days == 1 ? "1 day" : $"{timeSpan.Days} days";
+            string timePart = timeSpan.ToString(@"hh\:mm\:ss");
+            return $"{daysPart}, {timePart}";
+        }


How does it handle differences like language/ 24h or 12h Am/Pm

How does it handle differences like language/ 24h or 12h Am/Pm

Normal people use the 24-hour clock. In any case, I didn't intend for this method to be universal. If someone needs it, they can always add their own extension method to this class with a different name or a different overload. I don't see any problem with that.

Normal people use the 24-hour clock. In any case, I didn't intend for this method to be universal. If someone needs it, they can always add their own extension method to this class with a different name or a different overload. I don't see any problem with that.

It's an API meant for many people to use. A lot of this code is pretty pointless or not helpful to many people.

Normal people use the 24-hour clock. In any case, I didn't intend for this method to be universal. If someone needs it, they can always add their own extension method to this class with a different name or a different overload. I don't see any problem with that.

It's an API meant for many people to use. A lot of this code is pretty pointless or not helpful to many people.

Write your own method and add it. Be sure to take into account the 250 official languages. Keep in mind that each language has its own vocabulary and grammar. I used one specific method for 99% of tasks. But you can add your own.

that why i don't see a point for HumanReadable on this one

I don't really see why we need a TimeSpanExtensions, this is basic ToString stuff

I don't really see why we need a TimeSpanExtensions, this is basic ToString stuff

And I repeat once again that the default ToString override isn't working as it should.

var timeSpan = TimeSpan.FromMinutes(1); Log.Debug(timeSpan.ToString()); Log.Debug(timeSpan.ToString("c")); Log.Debug(timeSpan.ToString("g")); Log.Debug(timeSpan.ToString("G")); Log.Debug(timeSpan.ToString(@"h\:mm\:ss")); Log.Debug(timeSpan.ToString(@"m\:ss")); Log.Debug(timeSpan.ToHumanReadable());

[2026-09-26 13:24:16.581 +03:00] [DEBUG] [ToolTestHelper] 00:01:00 [2026-09-26 13:24:16.596 +03:00] [DEBUG] [ToolTestHelper] 00:01:00 [2026-09-26 13:24:16.612 +03:00] [DEBUG] [ToolTestHelper] 0:01:00 [2026-09-26 13:24:16.628 +03:00] [DEBUG] [ToolTestHelper] 0:00:01:00.0000000 [2026-09-26 13:24:16.643 +03:00] [DEBUG] [ToolTestHelper] 0:01:00 [2026-09-26 13:24:16.658 +03:00] [DEBUG] [ToolTestHelper] 1:00 [2026-09-26 13:24:16.674 +03:00] [DEBUG] [ToolTestHelper] 01:00

I’ve slightly updated this method.

Log.Debug(TimeSpan.FromTicks(1).ToHumanReadable()); Log.Debug(TimeSpan.FromMilliseconds(1).ToHumanReadable()); Log.Debug(TimeSpan.FromSeconds(1).ToHumanReadable()); Log.Debug(TimeSpan.FromMinutes(1).ToHumanReadable()); Log.Debug(TimeSpan.FromHours(1).ToHumanReadable()); Log.Debug(TimeSpan.FromDays(1).ToHumanReadable()); Log.Debug(TimeSpan.FromDays(1).Negate().ToHumanReadable());

[2026-09-26 14:58:43.668 +03:00] [DEBUG] [ToolTestHelper] 0:00 [2026-09-26 14:58:43.683 +03:00] [DEBUG] [ToolTestHelper] 0:00 [2026-09-26 14:58:43.700 +03:00] [DEBUG] [ToolTestHelper] 0:01 [2026-09-26 14:58:43.715 +03:00] [DEBUG] [ToolTestHelper] 1:00 [2026-09-26 14:58:43.731 +03:00] [DEBUG] [ToolTestHelper] 01:00:00 [2026-09-26 14:58:43.746 +03:00] [DEBUG] [ToolTestHelper] 1:00:00:00 [2026-09-26 14:58:43.761 +03:00] [DEBUG] [ToolTestHelper] -1:00:00:00

I still think this should live outside of EXILED, and "ToString override isn't working as it should." is false, and I'm pretty sure you can use Cultures and DateTime to better represent what you need

I still think this should live outside of EXILED, and "ToString override isn't working as it should." is false, and I'm pretty sure you can use Cultures and DateTime to better represent what you need

There is no way to reproduce this method using IFormatProvider. You are delirious.

louis1706 · 2026-08-31T18:48:13Z

+        public static bool NextBool(this Random rnd)
+        {
+            return rnd.Next(2) == 0;
+        }


Pretty sure this is very badly optimised

Pretty sure this is very badly optimised

I don't see any particular problem here, but you can do it like this:
(rnd.Next() & 1) == 0

louis1706 · 2026-08-31T18:48:49Z

+        /// <summary>
+        /// Generate a random float.
+        /// </summary>
+        /// <param name="rnd"><see cref="Random"/> object.</param>
+        /// <param name="min">Minimum value.</param>
+        /// <param name="max">Maximum value.</param>
+        /// <returns>Random value between minimum and maximum.</returns>
+        public static float NextFloat(this Random rnd, float min, float max)
+        {
+            return (float)((rnd.NextDouble() * (max - min)) + min);
+        }
+
+        /// <summary>
+        /// Generate a random float.
+        /// </summary>
+        /// <param name="rnd"><see cref="Random"/> object.</param>
+        /// <param name="min">Minimum value.</param>
+        /// <param name="max">Maximum value.</param>
+        /// <returns>Random value between minimum and maximum.</returns>
+        public static float NextFloat(this Random rnd, double min, float max)
+        {
+            return (float)((rnd.NextDouble() * (max - min)) + min);
+        }
+
+        /// <summary>
+        /// Generate a random float.
+        /// </summary>
+        /// <param name="rnd"><see cref="Random"/> object.</param>
+        /// <param name="min">Minimum value.</param>
+        /// <param name="max">Maximum value.</param>
+        /// <returns>Random value between minimum and maximum.</returns>
+        public static float NextFloat(this Random rnd, float min, double max)
+        {
+            return (float)((rnd.NextDouble() * (max - min)) + min);
+        }
+
+        /// <summary>
+        /// Generate a random float.
+        /// </summary>
+        /// <param name="rnd"><see cref="Random"/> object.</param>
+        /// <param name="min">Minimum value.</param>
+        /// <param name="max">Maximum value.</param>
+        /// <returns>Random value between minimum and maximum.</returns>
+        public static float NextFloat(this Random rnd, double min, double max)
+        {
+            return (float)((rnd.NextDouble() * (max - min)) + min);
+        }


Doesn't Unity Random already handle some of these ?

Doesn't Unity Random already handle some of these ?

Because not everyone likes Random from unity.

Because not everyone likes Random from unity.

??? What is wrong with unity randoms?

Because not everyone likes Random from unity.

??? What is wrong with unity randoms?

What difference does it make to you? What changes for you? Use the randomness you want.

The difference is that there is a proper way to use the Engine and it's features, why do we need another random gen?

The difference is that there is a proper way to use the Engine and it's features, why do we need another random gen?

Alright, you've convinced me. I removed those overloads that return a float.

Mrhootyhoot1 · 2026-09-06T02:42:01Z

            where T : Door => Get(doorVariant) as T;

+        /// <summary>
+        /// Gets the door object associated with a specific <see cref="ButtonVariant"/>, or creates a new one if there isn't one.


Why would you create a new door if there is not a door associated with that buttonvariant?

Why would you create a new door if there is not a door associated with that buttonvariant?

fixed

Mrhootyhoot1 · 2026-09-06T02:43:19Z

        /// </summary>
        /// <param name="message">The message to be sent.</param>
-        public static void Error(string message) => Send($"[{Assembly.GetCallingAssembly().GetName().Name}] {message}", Discord.LogLevel.Error, ConsoleColor.DarkRed);
+        public static void Error(string message = "") => Send($"[{Assembly.GetCallingAssembly().GetName().Name}] {message}", Discord.LogLevel.Error, ConsoleColor.DarkRed);


Why would anyone call a method meant to print to the console without passing a string to the method to be printed?

Why would anyone call a method meant to print to the console without passing a string to the method to be printed?

Have you ever split console logs to make them easier to read?

then you could just \n ?

then you could just \n ?

Because I don't want to use \n. I want the methods in the Log class not to require any arguments from the user by default. I designed the code so that these changes wouldn't break any existing functionality.

… forgot how it behaves. My mistake.

louis1706 · 2026-10-04T15:01:58Z

why are you squashing all your commit ?

PUDGE133 · 2026-10-05T11:02:51Z

I squash commits because I can't revert changes any other way. Which specific parts of all this do you consider "breaking changes"?

github-actions Bot added API CustomModules labels Aug 26, 2026

github-actions Bot assigned PUDGE133 Aug 26, 2026

louis1706 reviewed Aug 31, 2026

View reviewed changes

PUDGE133 force-pushed the NewFeatures branch from 7d85cb3 to de125a4 Compare September 1, 2026 09:43

Mrhootyhoot1 reviewed Sep 6, 2026

View reviewed changes

PUDGE133 force-pushed the NewFeatures branch 2 times, most recently from 9fefd96 to 61f4978 Compare September 19, 2026 17:27

louis1706 requested changes Sep 20, 2026

View reviewed changes

Comment thread EXILED/Exiled.API/Enums/FirearmType.cs

PUDGE133 force-pushed the NewFeatures branch from aeb9920 to 0bbaeb8 Compare September 26, 2026 10:42

I haven't worked with the Flags attribute in a long time and simply…

ab2bd62

… forgot how it behaves. My mistake.

PUDGE133 force-pushed the NewFeatures branch from 0bbaeb8 to ab2bd62 Compare September 26, 2026 11:28

louis1706 added the breaking-changes label Oct 4, 2026

Conversation

PUDGE133 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Submission checklist

Other

Uh oh!

PUDGE133 commented Aug 26, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mrhootyhoot1 Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PUDGE133 Sep 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PUDGE133 Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PUDGE133 Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

PUDGE133 commented Aug 26, 2026 •

edited

Loading

Mrhootyhoot1 Sep 6, 2026 •

edited

Loading

PUDGE133 Sep 6, 2026 •

edited

Loading

PUDGE133 Sep 1, 2026 •

edited

Loading

PUDGE133 Oct 5, 2026 •

edited

Loading