Skip to content

test(convex): move visibility guard out of deploy sources - #44

Merged
EtanHey merged 1 commit into
masterfrom
security/convex-authz-typecheck
Oct 27, 2026
Merged

EtanHey merged 1 commit into
masterfrom
security/convex-authz-typecheck

Conversation

@EtanHey

@EtanHey EtanHey commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Summary

The production deploy of #43 stopped because Convex's separate TypeScript config does not include Vite's ImportMeta.glob types. Move the visibility regression test from convex/ to src/__tests__/ so backend typechecking and bundling exclude the Vite-only test.

Adjust its ten Convex imports and source-relative glob. The existing Vitest include already finds the new path. No backend functions, TypeScript configs, dependencies, or reference directives change. Git records an 83% rename with 11 changed lines.

Validation

  • npx --no-install tsc -p convex --noEmit: passed.
  • Targeted tests: 82 passed, including all 68 visibility checks.
  • Temporary public-export mutation: the module allow-list and per-export check failed as intended (2 failed / 67 passed). Probe reverted byte-for-byte.
  • One normal commit hook: 272 tests passed across 18 files, root TypeScript check and docs guard passed.
  • The initial mutation probe exposed ignored JavaScript emitted by the failed deploy shadowing TypeScript. Its unexpected passing result was retained; only timestamp-verified files from that failed attempt were removed before the source mutation check and final suite.

No production retry was performed. Production deployment awaits lead review and separate authorization.

Loop-record: implementer=codex/gpt-6.1-sol/high reviewer=none rounds=0/0 defects=0 role=worker

Bot policy

Repository instructions read. This test-only follow-up is routed to the security lead for review per the lead's explicit instruction; no additional reviewer or bot was started. Lead owns merge and any new deploy authorization.

— songscript-convex-authz (worker) · codex/gpt-6.1-sol

Keep Vite-only test loading outside Convex typechecking and bundling while preserving the API visibility regression guard.

Co-Authored-By: songscript-convex-authz running gpt-6.1-sol <noreply@openai.com>
@EtanHey EtanHey added the size:XS Tight-loop PR size: 20 or fewer hand-written lines changed label Oct 27, 2026
@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown

Deployment failed for project songscript with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/etanheys-projects?upgradeToPro=build-rate-limit

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@EtanHey
EtanHey merged commit 2634a54 into master Oct 27, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS Tight-loop PR size: 20 or fewer hand-written lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant