Repository navigation
test(convex): move visibility guard out of deploy sources - #44
Merged
Merged
Conversation
Keep Vite-only test loading outside Convex typechecking and bundling while preserving the API visibility regression guard. Co-Authored-By: songscript-convex-authz running gpt-6.1-sol <noreply@openai.com>
|
Deployment failed for project songscript with the following error: Learn More: https://vercel.com/etanheys-projects?upgradeToPro=build-rate-limit |
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The production deploy of #43 stopped because Convex's separate TypeScript config does not include Vite's
ImportMeta.globtypes. Move the visibility regression test fromconvex/tosrc/__tests__/so backend typechecking and bundling exclude the Vite-only test.Adjust its ten Convex imports and source-relative glob. The existing Vitest include already finds the new path. No backend functions, TypeScript configs, dependencies, or reference directives change. Git records an 83% rename with 11 changed lines.
Validation
npx --no-install tsc -p convex --noEmit: passed.No production retry was performed. Production deployment awaits lead review and separate authorization.
Loop-record: implementer=codex/gpt-6.1-sol/high reviewer=none rounds=0/0 defects=0 role=worker
Bot policy
Repository instructions read. This test-only follow-up is routed to the security lead for review per the lead's explicit instruction; no additional reviewer or bot was started. Lead owns merge and any new deploy authorization.
— songscript-convex-authz (worker) · codex/gpt-6.1-sol