Skip to content

Remove -b flag for C# parser - #846

Merged
mcserep merged 3 commits into
Ericsson:feature/csharp_pluginfrom
LakatosMark1:fix-820-csharp-parser
Oct 14, 2026
Merged

mcserep merged 3 commits into
Ericsson:feature/csharp_pluginfrom
LakatosMark1:fix-820-csharp-parser

Conversation

@LakatosMark1

@LakatosMark1 LakatosMark1 commented Mar 29, 2026 •

Copy link
Copy Markdown
Collaborator

Refactor C# parser to extract target DLLs from .csproj and populate build graph

Resolves #820

@mcserep mcserep changed the title Issue #820 Remove -b flag for C# parser Apr 14, 2026
@mcserep
mcserep self-requested a review April 14, 2026 09:05
@mcserep mcserep added Plugin: C# Issues related to the parsing and presentation of C# projects. Kind: Refactor 🔃 labels Apr 14, 2026
@mcserep mcserep added this to Lab and Roadmap Apr 14, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Roadmap Apr 14, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Lab Apr 14, 2026
@mcserep mcserep linked an issue Apr 14, 2026 that may be closed by this pull request
@mcserep mcserep added this to the Upcoming Release milestone Apr 14, 2026
Comment thread plugins/csharp/parser/include/csharpparser/csharpparser.h Outdated
bool CsharpParser::parseProjectBuildPath(
const std::vector<std::string>& paths_,
const std::string& buildPath_)
const std::vector<std::string>& paths_ //,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out comma.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LakatosMark1 This is still a pending formatting issue.

Comment thread plugins/csharp/parser/src_csharp/Program.cs Outdated
Comment thread plugins/csharp/parser/src_csharp/Program.cs
Comment thread plugins/csharp/parser/src_csharp/Program.cs Outdated
@LakatosMark1

Copy link
Copy Markdown
Collaborator Author

I have made the canges requested!

@mcserep mcserep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost ready now, some final touches and questions remain.

Comment thread plugins/csharp/parser/src/csharpparser.cpp Outdated
Comment thread plugins/csharp/parser/src_csharp/Program.cs Outdated
- Implemented 'JSON_READY:' prefix in C# and C++ for robust IPC stream handling
- Fixed EF Core duplicate Id tracking exception in AstVisitor
- Replaced 'Unknown.dll' fallback with empty string as requested
@mcserep
mcserep merged commit 5c1c4b9 into Ericsson:feature/csharp_plugin Oct 14, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Roadmap Oct 14, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in Lab Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kind: Refactor 🔃 Plugin: C# Issues related to the parsing and presentation of C# projects.

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Refactor the -b flag of the C# plugin

2 participants