Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request fixes a
NoMethodErrorinvite_padrinowhen an entrypoint imports a shared chunk.Background 📜
This was happening because
vite_preload_tagcallstry(:request), andtrycomes from ActiveSupport, which Padrino doesn't load. Vite emits a modulepreload tag whenever two entrypoints import the same module, so any such app crashes when renderingvite_javascript_tag:The Fix 🔨
By changing the
trycalls to plainrespond_to?checks. Early hints are still sent when the request supports them.Screenshots 📷
N/A. Tested with a generated Padrino app with two entrypoints sharing a module, after
vite build: before, a 500 error; after, a 200 with the<link rel="modulepreload">tag rendered.