TSM-10: convert Group E services to TypeScript - #567
Open
Justin Hammond (Justintime50) wants to merge 61 commits into
Open
TSM-10: convert Group E services to TypeScript#567Justin Hammond (Justintime50) wants to merge 61 commits into
Justin Hammond (Justintime50) wants to merge 61 commits into
Conversation
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 7, 2026 20:49
69c8c8b to
93e68fb
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 16:35
93e68fb to
c90af9b
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 17:01
c90af9b to
8933de0
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 17:20
8933de0 to
9622437
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 20:07
9622437 to
300b5f2
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 20:22
300b5f2 to
5bc2d21
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 11, 2026 20:25
5bc2d21 to
94962c3
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 12, 2026 16:59
94962c3 to
ec215aa
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 12, 2026 17:10
ec215aa to
77937f5
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
2 times, most recently
from
August 12, 2026 17:21
4a8ec7d to
28d3ae6
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 12, 2026 17:22
28d3ae6 to
76e1f34
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 12, 2026 17:26
76e1f34 to
916d36e
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
2 times, most recently
from
August 12, 2026 17:27
a52c884 to
d1308b6
Compare
Justin Hammond (Justintime50)
marked this pull request as ready for review
August 12, 2026 20:27
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/10-services-group-e
branch
from
August 24, 2026 19:24
518df81 to
552d812
Compare
Alex Matthews (ralexmatthews)
approved these changes
Aug 31, 2026
Alex Matthews (ralexmatthews)
left a comment
Alex Matthews (ralexmatthews)
left a comment
Contributor
There was a problem hiding this comment.
Few comments, nothing blocking
Comment on lines
+39
to
+41
| user.children?.forEach((child) => { | ||
| if (child.id == id) { | ||
| return child.keys; | ||
| return child.keys ?? []; |
Contributor
There was a problem hiding this comment.
Issue:
This is unrelated to your changes here, but I don't think this would actually work the way it looks like is intended here. This return child.keys ?? []; only returns in the forEach arrow fn, not for the outside scope. If you wanted to return those child keys from the retrieveApiKeysForUser outside fn, you would need to either do like a user.children?.find and return that, or change this to like a for (child in user.children ?? []) { loop.
Comment on lines
+25
to
+26
| /* eslint-disable no-unused-vars */ | ||
| type ReferralScopedClient = { |
Contributor
There was a problem hiding this comment.
question:
Is this temporary, or is there a reason we are keeping this arround?
Comment on lines
+61
to
+62
| const body = response.body as Record<string, unknown>; | ||
| return body.public_key as string; |
Contributor
There was a problem hiding this comment.
thought:
If we are asserting the type anyway, we could shorten this to
const body = response.body as { public_key: string };
return body.public_key;| referralApiKey: string, | ||
| stripeCreditCardToken: string, | ||
| priority: string, | ||
| ): Promise<Record<string, unknown>> { |
Contributor
There was a problem hiding this comment.
nit:
Unspecific return type here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation