Repository navigation
1.0.0 build 33: make Shift and ⌥M actually keep the code - #213
Merged
Merged
Conversation
…e to build 32 Both machines now run 1.0.0 build 32 (host executable ddd33b7a…), and the trial baseline follows, since IT-23 has not started counting yet. Signed-off-by: wangzhizhou <824219521@qq.com>
Report 222: build 32 passed only the width case because the two other paths live in the host, not in the core. A lone Shift press goes through flagsChanged and called shiftTransition, which swallows the buffer and then cleared the marked text; the menu handler I patched earlier was never reached. The raw code is now captured before the transition and inserted afterwards. Cycling modes called cancelClientComposition() before setMode, so the composition died no matter what the core did; it now sets the mode, shows the chip feedback and refreshes marked text and candidates. Build 33. Signed-off-by: wangzhizhou <824219521@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build 32 只通过了 ⌥F（全角）——另外两条被我改在了没被走到的地方（报告 222）。
1. Shift 为什么仍丢字
键盘单独 Shift 走
flagsChanged→session.shiftTransition(...)（内部toggleEnglish()→ corecancel()），随后clearMarked+hide()。我上一版改的toggleEnglish(_:)是菜单/快捷键那条路，键盘根本走不到。修法：在
shiftTransition之前把编码取出来，切换后clearMarked+insertText(raw)原样上屏。2. ⌥M 为什么仍丢字
applyInputMode()里session?.setMode(next)之前调了cancelClientComposition()——先把组合取消掉，核心再怎么保留也没意义。修法：去掉那次取消，改为
setMode→ 芯片反馈 →refreshAfterStateChange()（预编辑与候选按新模式刷新）。验证
test-controller-menu通过；make verifyPASS；make macos-offline-tests56 文件 / 303 例 PASSnihao字母）；打字出候选 → ⌥M（候选框不消失、候选按新模式刷新）