Skip to content

Add Visit preconfigure hook - fix zlib detection for Visit #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavelToman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Visit preconfigure hook - fix zlib detection for Visit #305

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0584552
Add Visit preconfigure hook for zlib
pavelToman Sep 16, 2026
7697c55
Update eb_hooks.py
pavelToman Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1670,6 +1670,29 @@ def pre_configure_hook_cmake_system(self, *args, **kwargs):
raise EasyBuildError("CMake-specific hook triggered for non-CMake easyconfig?!")


def pre_configure_hook_visit(self, *args, **kwargs):
"""
Pre-configure hook for Visit
- make sure that zlib is found in compat layer
"""
if self.name == 'Visit':
if 'zlib' in build_option('filter_deps'):
compat_layer_topdir = get_eessi_envvar('EESSI_EPREFIX')
zlib_dir = os.path.join(compat_layer_topdir, 'usr')
zlib_opt = f'-DVISIT_ZLIB_DIR={zlib_dir}'

if '-DVISIT_ZLIB_DIR' in self.cfg['configopts']:
self.cfg['configopts'] = re.sub(
r'-DVISIT_ZLIB_DIR=\S*',
zlib_opt,
self.cfg['configopts'],
)
else:
self.cfg.update('configopts', zlib_opt)
else:
raise EasyBuildError("Visit-specific hook triggered for non-Visit easyconfig?!")


def pre_configure_hook_Zoltan(self, *args, **kwargs):
"""
Pre-configure hook for Zoltan to filter out ParMETIS configure options,
Expand Down Expand Up @@ -2413,6 +2436,7 @@ def post_easyblock_hook(self, *args, **kwargs):
'ROCm-LLVM': pre_configure_hook_llvm,
'Score-P': pre_configure_hook_score_p,
'SymEngine': pre_configure_hook_symengine,
'Visit': pre_configure_hook_visit,
'WRF': pre_configure_hook_wrf_aarch64,
'Zoltan': pre_configure_hook_Zoltan,
}
Expand Down