Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 관련 이슈
Resolved #468
💡작업 내용
1. 축제 제휴 안내 말풍선 번역 추가
map.festivalBannerMessage가 한국어에만 있어, 다른 언어에서 한국어로 노출되던 문제map.festival번역(Festival / 学園祭 / Lễ hội)에 맞춰 "축제"로 옮김Not valid with other partner deals.
既存の提携とは併用できません。
Không áp dụng cùng ưu đãi khác.
2. 리뷰 작성 시 리뷰 종류가 바뀌는 문제
SetRateViewController.dataBind가 메뉴 개수로 리뷰 종류를 다시 정하고 있었음mealID없음 안내만 뜨고 제출 불가init(mealId:)/init(menuId:)에서 정한 값을 그대로 쓰도록 분기 제거 (수정 흐름dataBindForFix는 그대로)restoreSubmitState())테스트: 유닛 44개 통과, 번역 파일
plutil -lint통과💬리뷰 요구사항(선택)