Repository navigation
sdn-js: FlatSQL 3.12.10 (the engine returns an error instead of aborting when a thread cannot start) - #203
Merged
Conversation
… status, not an abort) flatsql 3.12.9 -> 3.12.10 from the registry (lockfile with integrity); nothing else. FlatSQL 3.12.10: flatsql_start creates every engine thread before any runs and returns FLATSQL_E_BUSY when one cannot be created, with nothing started; the browser guest reports it as FlatSQLThreadPoolError, Node as FlatSQLError -6. Served files that change: flatsql.wasm, integrity.json, runtime/browser-guest.mjs, index.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
sdn-js/package.json:flatsql3.12.9 -> 3.12.10 (exact).sdn-js/package-lock.jsoncomes from the registry, with integrity. Nothing else; main's other pins are kept.npm ciis clean.flatsql_startcreates every engine thread before any runs. When one cannot be created, it starts none and returnsFLATSQL_E_BUSY(-6), instead ofstd::threadaborting the WASM instance (RuntimeError: unreachableinstartThreads).FlatSQLThreadPoolError, as it already does for a short thread pool; Node reportsFlatSQLError-6.Served files that change (
/sdn-js/on the site, sha256)index.mjschanges because it bundles FlatSQL'sindex.js, which has the new status message.flatsql.wasmis byte for byte the artifact built and tested on the FlatSQL release branch.Browser proof (
sdn-js/scripts/catalog-cache-threads.e2e.mjs, built runtime, 30 fresh contexts each)The catalog cache opens and reads on OPFS with the places store in memory, the way the console does. The whole browser is slowed by stopping and continuing its processes.
Checks
engine-record-store,engine-record-store-stream-surface,local-flatsql-durable,local-flatsql-schema,flatsql-parity,flatsql-sync-cutoff): 6 files, 35 tests, pass.src/package-build.test.ts: 16 tests, pass.scripts/check.mjs --repo . --base origin/main --e2e "cmd node sdn-js/scripts/catalog-cache-threads.e2e.mjs --contexts 30 --cpu 4 --script-delay-ms 2300", with the stack's origin/main check files (0422bad3), ended CHECK FAILED.json-boundary sdnfound 1 new JSON hit (698 against a baseline of 697), atsdn-server/internal/pubsub/publication_observation.goline 33, inpublishObservedDatasetAnnouncement(R4-p2p-json). That file is not in this change (the diff issdn-js/package.jsonand its lockfile only). It came to main with 2f6b54d ("Add integrity rejection coverage and publication timing observations"), so main fails this scan on its own.🤖 Generated with Claude Code