Repository navigation
Export the host ABI as its own entry: space-data-module-sdk/host/abi - #22
Merged
Merged
Conversation
createHostcallBridge and the host dispatchers were reachable only through the package root. A browser consumer that needs the bridge alone had to import the root, whose browser entry re-exports the runtime host and with it the FlatSQL runtime store. The new entry names src/host/abi.js directly: it bundles for a browser without the runtime host, FlatSQL or a Node builtin. The entry joins the browser-facing list of test/browser-reachable-node-builtins.test.js and passes there. That test fails on main before this change for the root and for ./runtime-host, which reach Node builtins through the FlatSQL package entry; this change neither causes nor fixes that. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createHostcallBridgeand the host dispatchers were reachable only through the package root. A browser consumer that needs the bridge alone had to import the root, whose browser entry re-exports the runtime host and, with it, the FlatSQL runtime store. A bundler that emits an IIFE then fails on the top-levelawaitin FlatSQL's Node host.This adds one entry to the export map,
./host/abi(src/host/abi.js), a changelog line under 0.10.3, and the entry in the browser-facing list oftest/browser-reachable-node-builtins.test.js.Checked
src/host/abi.jsfor a browser as an IIFE succeeds: 53 inputs, none from the runtime host or FlatSQL.createHostcallBridge.test/browser-reachable-node-builtins.test.js: the new entry reaches no Node builtin.Already failing on main, not changed here
.) and for./runtime-host: both reachnode:fs,node:crypto,node:osandnode:paththroughsrc/runtime-host/flatsqlRuntimeStore.jsand the FlatSQL package entry. The failing set is identical with and without this change.src/compiler/compileModule.jsandsrc/compiler/guestLinkLibraries.js, files this change does not touch.🤖 Generated with Claude Code
https://claude.ai/code/session_01PT7jJcdnhrPX14f8BuYuZy