Repository navigation
feat(discord): webhook messages follow the app language - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discord_language(autodefault = app language,en,es), exposed throughSettingsApi(send_test_notification(..., language=)).i18n.catalog,resolve_language,format_number(language=)), independent of the UI's current language and thread-safe for the webhook worker.Quality evidence
py tools/qa_gate.py: 8/8 READY (1717 tests passed, diff coverage 96%+).tests/test_discord_language.py: en/es defaults, auto follows app language, override wins, templates untouched, durations, plurals, test message; dialog tests for label/key saving.retry=None) fixed with a regression test.