[debugger] Add Go repro tests for map lookups, static template errors and missing-key conditions by timsee · Pull Request #8201 · DataDog/system-tests

timsee · 2026-10-27T20:04:12Z

Motivation

Go's Dynamic Instrumentation gets three map expressions wrong in staging, and the existing tests don't catch any of them:

Map lookups return unavailable. m["AAA"] names a key that exists, but the captured value is unavailable. The existing test_complex_capture_expressions only checks that the value has a type, so a not-captured marker still passes.
Known-bad templates stay installed. A member access on a map (m.AAA), an unknown variable (nope_var) or a missing struct field (req.Nope) in a condition is rejected at install. The same expressions in a log template install fine and only print the error inside the log line.
A missing-key condition fires. m["ZZZ"] == 1 fired as if true, with no error. A missing key in a map[string]int reads as 0, so the condition should be false.

Changes

test_complex_capture_expressions_dictionary_value: requires testStruct.Dictionary['two'] to capture 2.
Test_Debugger_Go_Static_Template_Error: templates using testStruct.Dictionary.two, an unknown variable, or a missing struct field must each reach ERROR, like the equivalent conditions.
Test_Debugger_Go_Missing_Map_Key_Condition: testStruct.Dictionary['nope'] == 1 must not produce a snapshot with captured data.

The two new classes are scoped to Go. Draft: opened to get Linux CI results, since Go DI can't run on a macOS Docker VM. Manifests will be updated with tickets once CI shows which tests fail.

…ue errors

github-actions · 2026-10-27T20:04:47Z

CODEOWNERS have been resolved as:

tests/debugger/test_debugger_go_expression_errors.py                    @DataDog/debugger
tests/debugger/utils/probes/probe_missing_map_key_condition.json        @DataDog/debugger
tests/debugger/utils/probes/probe_static_template_error.json            @DataDog/debugger
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
tests/debugger/test_debugger_capture_expressions.py                     @DataDog/debugger

…-key condition

…late test

datadog-official · 2026-10-27T20:32:12Z

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 24 Pipeline jobs failed

Testing the test | System Tests (golang, dev) / End-to-end #1 / chi 1 — ❌ 2 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition.test_missing_map_key_condition_does_not_fire[chi]

from system_tests_suite

AssertionError: The probe emitted a snapshot with captured data, so the condition fired as if true. A missing key in a map[string]int reads as 0, and 0 == 1 is false.
assert not True
 &#43;  where True = &lt;function captures_contain_data at 0x7f07fb64d1c0&gt;({&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x20bbb40&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...fields&#39;: {...}, &#39;type&#39;: &#39;*github.com/go-chi/chi/v5/middleware.httpFancyWriter&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}})
 &#43;    where &lt;function captures_contain_data at 0x7f07fb64d1c0&gt; = debugger.captures_contain_data
 &#43;    and   {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x20bbb40&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...fields&#39;: {...}, &#39;type&#39;: &#39;*github.com/go-chi/chi/v5/middleware.httpFancyWriter&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}} = &lt;built-in method get of dict object at 0x7f07dbfae2c0&gt;(&#39;captures&#39;)
 &#43;      where &lt;built-in method get of dict object at 0x7f07dbfae2c0&gt; = {&#39;captures&#39;: {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x20bbb40&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;},... == 1&#34;, &#39;message&#39;: &#39;error evaluating condition&#39;}], &#39;id&#39;: &#39;7cdfc80f-1fe9-4e65-aec6-337fa06fb81e&#39;, &#39;language&#39;: &#39;go&#39;, ...}.get

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition object at 0x7f07fbea9010&gt;

    def test_missing_map_key_condition_does_not_fire(self) -&gt; None:
...

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error.test_static_template_error_probe_rejected[chi]

from system_tests_suite

AssertionError: Probe reached status &#39;EMITTING&#39;; its template can never evaluate, so it must be rejected with status=ERROR like the equivalent condition.
assert &#39;EMITTING&#39; == &#39;ERROR&#39;
  - ERROR
  &#43; EMITTING

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error object at 0x7f07fbeaabd0&gt;

    def test_static_template_error_probe_rejected(self) -&gt; None:
        &#34;&#34;&#34;Each template references something the system-probe resolves at install time and can&#39;t find.
    
...

Testing the test | System Tests (golang, dev) / End-to-end #1 / echo 1 — ❌ 2 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition.test_missing_map_key_condition_does_not_fire[echo]

from system_tests_suite

AssertionError: The probe emitted a snapshot with captured data, so the condition fired as if true. A missing key in a map[string]int reads as 0, and 0 == 1 is false.
assert not True
 &#43;  where True = &lt;function captures_contain_data at 0x7f6067db1440&gt;({&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x217e560&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...a&#39;: {&#39;address&#39;: &#39;0xc91c620d860&#39;, &#39;fields&#39;: {...}, &#39;type&#39;: &#39;*net/http.response&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}})
 &#43;    where &lt;function captures_contain_data at 0x7f6067db1440&gt; = debugger.captures_contain_data
 &#43;    and   {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x217e560&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...a&#39;: {&#39;address&#39;: &#39;0xc91c620d860&#39;, &#39;fields&#39;: {...}, &#39;type&#39;: &#39;*net/http.response&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}} = &lt;built-in method get of dict object at 0x7f604890a5c0&gt;(&#39;captures&#39;)
 &#43;      where &lt;built-in method get of dict object at 0x7f604890a5c0&gt; = {&#39;captures&#39;: {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x217e560&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;},... == 1&#34;, &#39;message&#39;: &#39;error evaluating condition&#39;}], &#39;id&#39;: &#39;e8c5044e-6dd6-431a-bfbc-24f14d4fd127&#39;, &#39;language&#39;: &#39;go&#39;, ...}.get

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition object at 0x7f60747c8a40&gt;

    def test_missing_map_key_condition_does_not_fire(self) -&gt; None:
...

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error.test_static_template_error_probe_rejected[echo]

from system_tests_suite

AssertionError: Probe reached status &#39;EMITTING&#39;; its template can never evaluate, so it must be rejected with status=ERROR like the equivalent condition.
assert &#39;EMITTING&#39; == &#39;ERROR&#39;
  - ERROR
  &#43; EMITTING

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error object at 0x7f60747c8110&gt;

    def test_static_template_error_probe_rejected(self) -&gt; None:
        &#34;&#34;&#34;Each template references something the system-probe resolves at install time and can&#39;t find.
    
...

Testing the test | System Tests (golang, dev) / End-to-end #1 / fiber-v2-orchestrion 1 — ❌ 2 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitHub Actions

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition.test_missing_map_key_condition_does_not_fire[fiber-v2-orchestrion]

from system_tests_suite

AssertionError: The probe emitted a snapshot with captured data, so the condition fired as if true. A missing key in a map[string]int reads as 0, and 0 == 1 is false.
assert not True
 &#43;  where True = &lt;function captures_contain_data at 0x7f2d871253a0&gt;({&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x242e8a0&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...&#39;fields&#39;: {...}, &#39;type&#39;: &#39;*github.com/valyala/fasthttp/fasthttpadaptor.writer&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}})
 &#43;    where &lt;function captures_contain_data at 0x7f2d871253a0&gt; = debugger.captures_contain_data
 &#43;    and   {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x242e8a0&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;}, &#39;r&#39;: {&#39;addre...&#39;fields&#39;: {...}, &#39;type&#39;: &#39;*github.com/valyala/fasthttp/fasthttpadaptor.writer&#39;}}, &#39;type&#39;: &#39;net/http.ResponseWriter&#39;}}}} = &lt;built-in method get of dict object at 0x7f2d66887380&gt;(&#39;captures&#39;)
 &#43;      where &lt;built-in method get of dict object at 0x7f2d66887380&gt; = {&#39;captures&#39;: {&#39;entry&#39;: {&#39;arguments&#39;: {&#39;d&#39;: {&#39;address&#39;: &#39;0x242e8a0&#39;, &#39;fields&#39;: {}, &#39;type&#39;: &#39;*main.DebuggerController&#39;},... == 1&#34;, &#39;message&#39;: &#39;error evaluating condition&#39;}], &#39;id&#39;: &#39;cc4de381-d661-4e9b-ba43-84c811b50b4f&#39;, &#39;language&#39;: &#39;go&#39;, ...}.get

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Missing_Map_Key_Condition object at 0x7f2d8742b080&gt;

    def test_missing_map_key_condition_does_not_fire(self) -&gt; None:
...

❌

tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error.test_static_template_error_probe_rejected[fiber-v2-orchestrion]

from system_tests_suite

AssertionError: Probe reached status &#39;EMITTING&#39;; its template can never evaluate, so it must be rejected with status=ERROR like the equivalent condition.
assert &#39;EMITTING&#39; == &#39;ERROR&#39;
  - ERROR
  &#43; EMITTING

self = &lt;tests.debugger.test_debugger_go_expression_errors.Test_Debugger_Go_Static_Template_Error object at 0x7f2d8742ae70&gt;

    def test_static_template_error_probe_rejected(self) -&gt; None:
        &#34;&#34;&#34;Each template references something the system-probe resolves at install time and can&#39;t find.
    
...

View all 24 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: a121cd1 | Docs | View more details | Give us feedback!}

…uby and .NET

[debugger] Add repro tests for map index values and silent metric val…

d41d61b

…ue errors

timsee added 2 commits October 27, 2026 16:07

[debugger] Annotate evaluation_errors for mypy

ccbde9e

[debugger] Scope repro tests to Go: static template error and missing…

32eb30c

…-key condition

timsee changed the title ~~[debugger] Add repro tests for map index values and silent metric value errors~~ [debugger] Add Go repro tests for map lookups, static template errors and missing-key conditions Oct 27, 2026

timsee added 2 commits October 27, 2026 16:13

[debugger] Type install statuses as ProbeStatus

12232fc

[debugger] Cover unknown variable and missing field in Go static temp…

5655297

…late test

[debugger] Gate dictionary value test like complex capture test for R…

a121cd1

…uby and .NET

Navigation Menu

Repository navigation

[debugger] Add Go repro tests for map lookups, static template errors and missing-key conditions - #8201

[debugger] Add Go repro tests for map lookups, static template errors and missing-key conditions#8201
timsee wants to merge 6 commits into
mainfrom
timsee/di-el-bug-repros

timsee commented Oct 27, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 27, 2026 •

edited

Loading

Uh oh!

datadog-official Bot commented Oct 27, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

timsee commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Uh oh!

github-actions Bot commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official Bot commented Oct 27, 2026 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Errors

ℹ️ Info

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

timsee commented Oct 27, 2026 •

edited

Loading

github-actions Bot commented Oct 27, 2026 •

edited

Loading

datadog-official Bot commented Oct 27, 2026 •

edited by datadog-datadog-prod-us1 Bot

Loading