Skip to content

[php] Skip 3 debugger tests on ZTS weblogs for dev versions (DEBUG-6443) - #8200

Closed
cbeauchesne wants to merge 5 commits into
mainfrom
cbeauchesne/php-zts-debugger-skip
Closed

cbeauchesne wants to merge 5 commits into
mainfrom
cbeauchesne/php-zts-debugger-skip

Conversation

@cbeauchesne

@cbeauchesne cbeauchesne commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

On PHP dev (1.27.0+dev), 3 debugger tests fail on the -zts Apache weblogs with Probes did not reach INSTALLED status (DEBUG-6443).

Changes

Declare them as bug (DEBUG-6443) for >=1.27.0-dev on the ZTS weblogs:

  • Test_Debugger_Method_Capture_Expressions::test_method_parameter_capture_expressions
  • Test_Debugger_Expression_Language::test_expression_language_access_variables
  • Test_Debugger_Method_Probe_Snaphots_With_SCM::test_log_method_snapshot

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/php.yml                                                       @DataDog/system-tests-reviewers

@cbeauchesne
cbeauchesne marked this pull request as ready for review October 27, 2026 17:21
@cbeauchesne
cbeauchesne requested a review from a team as a code owner October 27, 2026 17:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T17:23:31.907908Z 4e7bff3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7835d84 | Docs | View more details | Give us feedback!

…(DEBUG-6443)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cbeauchesne
cbeauchesne enabled auto-merge (squash) October 27, 2026 18:05
@cbeauchesne
cbeauchesne disabled auto-merge October 27, 2026 23:26
@cbeauchesne

Copy link
Copy Markdown
Collaborator Author

Should be fixed by DataDog/dd-trace-php#4388

@cbeauchesne
cbeauchesne deleted the cbeauchesne/php-zts-debugger-skip branch October 28, 2026 15:32
@p-datadog

p-datadog commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

We tracked DEBUG-6443 down to dd-trace-php #4375: its SIGVTALRM guard kept the signal blocked on Apache ZTS weblogs, so remote-config notifications were never delivered and debugger probes never reached INSTALLED status. The fix in dd-trace-php #4388 (a42da68a) landed before any 1.27.0 release, and every master system-tests run since is green on all zts weblogs for the debugger scenarios.

Given that, it feels like these skips would now disable passing tests on the zts weblogs for dev builds — the very coverage that caught this bug. Unless there's something else keeping this open, I'd suggest closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants