Repository navigation
[php] Skip 3 debugger tests on ZTS weblogs for dev versions (DEBUG-6443) - #8200
cbeauchesne wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 7835d84 | Docs | View more details | Give us feedback! |
…(DEBUG-6443) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Should be fixed by DataDog/dd-trace-php#4388 |
|
We tracked DEBUG-6443 down to dd-trace-php #4375: its SIGVTALRM guard kept the signal blocked on Apache ZTS weblogs, so remote-config notifications were never delivered and debugger probes never reached INSTALLED status. The fix in dd-trace-php #4388 (a42da68a) landed before any 1.27.0 release, and every master system-tests run since is green on all zts weblogs for the debugger scenarios. Given that, it feels like these skips would now disable passing tests on the zts weblogs for dev builds — the very coverage that caught this bug. Unless there's something else keeping this open, I'd suggest closing it. |
Motivation
On PHP dev (
1.27.0+dev), 3 debugger tests fail on the-ztsApache weblogs withProbes did not reach INSTALLED status(DEBUG-6443).Changes
Declare them as
bug (DEBUG-6443)for>=1.27.0-devon the ZTS weblogs:Test_Debugger_Method_Capture_Expressions::test_method_parameter_capture_expressionsTest_Debugger_Expression_Language::test_expression_language_access_variablesTest_Debugger_Method_Probe_Snaphots_With_SCM::test_log_method_snapshot🤖 Generated with Claude Code