Repository navigation
[debugger] Enable .NET in-product Code Origin enablement test from 3.56.0 - #8123
Merged
Merged
Conversation
…t enablement test Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
|
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 452d5e2 | Docs | View more details | Give us feedback! |
…56.0 Co-authored-by: Cursor <cursoragent@cursor.com>
dudikeleti
changed the title
dudikeleti
added a commit
that referenced
this pull request
Oct 27, 2026
DataDog/dd-trace-dotnet#9344 merged after 3.56.0 was released, so the first release with the fix is 3.57.0. Code origin enablement doesn't depend on #9344 and is enabled from 3.56.0 in #8123, so this PR no longer touches it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dudikeleti
marked this pull request as ready for review
October 27, 2026 08:59
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8718444d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address review feedback: - The in-product code origin setup warmed up only Node.js before checking the default state. Code origin can start asynchronously, so warm up for every library. Where code origin is off by default, the warmup waits for its whole timeout. - Quote component_version '<3.56.0' in dotnet.yml. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
watson
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Test_Debugger_InProduct_Enablement_Code_Originasserts that code origin is off at startup for every library except Node.js. .NET turned code origin on by default in3.45.0(DEBUG-4174, checked byTest_Debugger_InProduct_Enablement_Code_Origin_Default_Onfromv3.45.0), so on .NET this assertion fails before the remote config part of the test even runs.With that assertion fixed, the test passed in the CI of #7876 (run 38560367253, .NET
dev3.56.0from dd-trace-dotnetmaster) onpoc. That run didn't use DataDog/dd-trace-dotnet#9344, so code origin doesn't depend on it.3.56.0is now released, and this PR'sdotnet prodjob passes the test on it (poc).Changes
test_inproduct_enablement_code_origin: expect code origin on at startup for .NET, like Node.js.manifests/dotnet.yml: limitbug (DEBUG-4637)onTest_Debugger_InProduct_Enablement_Code_Origintocomponent_version: <3.56.0.Test_Debugger_InProduct_Enablement_Dynamic_Instrumentationandtest_inproduct_enablement_exception_replay_apm_multiconfigstaybug (DEBUG-4637). They need DataDog/dd-trace-dotnet#9344, which merged after3.56.0was released and ships in3.57.0. #7876 enables them from3.57.0.Workflow
system-tests-reviewers: ask to one of youre co-worker familiar with the tested feature.system-tests-core(slack)🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟