Repository navigation
Enable Java serial ID metadata system tests - #7854
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoOct 16, 2026
Merged
Conversation
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: d95a35a | Docs | View more details | Give us feedback! |
hhan2024
force-pushed
the
ffe-serial-id-metadata-system-test
branch
from
September 30, 2026 16:24
9547cef to
ea6ec3f
Compare
hhan2024
requested review from
danyal002 and
sameerank
and removed request for
a team
September 30, 2026 16:24
danyal002
approved these changes
Sep 30, 2026
danyal002
approved these changes
Sep 30, 2026
sameerank
approved these changes
Oct 2, 2026
nccatoni
approved these changes
Oct 8, 2026
nccatoni
left a comment
nccatoni
left a comment
Collaborator
There was a problem hiding this comment.
Looks like there is a merge conflict with utils/pytest.py, otherwise LGTM
hhan2024
force-pushed
the
ffe-serial-id-metadata-system-test
branch
from
October 15, 2026 17:12
b59cca6 to
4352704
Compare
Forward OpenFeature evaluation details and enable serial ID coverage for Java 1.66.0. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
hhan2024
force-pushed
the
ffe-java-serial-id-metadata
branch
from
October 16, 2026 18:09
faaae90 to
d95a35a
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
ffe-java-serial-id-metadata
branch
October 16, 2026 18:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the shared serial-ID tests merged in #7820.
get*DetailsAPIs and forward actualflagMetadatain/ffe/evaluateresponses.No Java SDK change is necessary: DDEvaluator already includes the selected split's serial ID when span enrichment is enabled, preserving zero and omitting missing IDs. The old test adapter called only
get*Value, which discarded this metadata.The shared assertions and the other SDK manifests are unchanged.
Validation
After rebasing onto main: rebuilt the parametric adapter; all 29 serial-ID and dynamic-evaluation tests passed with Java 1.67.1+5941040e7e.
./format.sh --checkpassed../format.sh— passed.TEST_LIBRARY=java ./run.sh PARAMETRIC -n=2 tests/parametric/test_ffe/test_serial_id_metadata.py tests/parametric/test_ffe/test_dynamic_evaluation.py— 29 passed, no skips (Java 1.66.0+a099fffb31): all 5 serial-ID cases plus 24 dynamic-evaluation regression cases, including structured JSON, integer, numeric, and falsy values.