Skip to content

Enable serial ID flag metadata tests for Node.js - #7852

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
ffe-nodejs-serial-id-metadata
Oct 16, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
ffe-nodejs-serial-id-metadata

Conversation

@hhan2024

@hhan2024 hhan2024 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Uses the shared serial-ID tests merged in #7820.

  • Use OpenFeature get*Details APIs in the Node.js parametric adapter and forward the actual SDK value, reason, and flagMetadata.
  • Preserve a null metadata field when the SDK supplies no metadata; do not construct serial IDs in the adapter.
  • Enable the serial-ID tests for Node.js from v6.18.0, the released version validated locally. This is a conservative verified floor, not a claim that earlier releases fail.

The released Node.js SDK already exposes __dd_split_serial_id, so no SDK implementation change is needed.

Validation

  • After rebasing onto main: rebuilt the parametric adapter; all 29 serial-ID and dynamic-evaluation tests passed with Node.js 6.21.0. ./format.sh --check passed.
  • Node.js dd-trace 6.18.0: 29 passed without force-execution (5 serial-ID tests + 24 dynamic-evaluation tests).
  • Positive IDs and zero are preserved; missing IDs are absent, with span enrichment enabled.
  • ./format.sh passed.
  • node --check and git diff --check passed.

Command: TEST_LIBRARY=nodejs ./run.sh PARAMETRIC --skip-parametric-build tests/parametric/test_ffe/test_serial_id_metadata.py tests/parametric/test_ffe/test_dynamic_evaluation.py

@hhan2024
hhan2024 requested a review from a team as a code owner September 29, 2026 15:31
@github-actions

Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
utils/build/docker/nodejs/parametric/server.js                          @DataDog/system-tests-reviewers

@datadog-official

datadog-official Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7d614be | Docs | View more details | Give us feedback!

@hhan2024
hhan2024 force-pushed the ffe-serial-id-metadata-system-test branch from 9547cef to ea6ec3f Compare September 30, 2026 16:24
@hhan2024
hhan2024 requested review from a team as code owners September 30, 2026 16:24
@hhan2024
hhan2024 requested review from typotter and vjfridge and removed request for a team September 30, 2026 16:24

@nccatoni nccatoni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a merge conflict with utils/pytest.py otherwise LGTM. You should also get a review from someone familiar whit the feature

@typotter typotter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending merge conflicts

@hhan2024
hhan2024 force-pushed the ffe-serial-id-metadata-system-test branch from b59cca6 to 4352704 Compare October 15, 2026 17:12
Base automatically changed from ffe-serial-id-metadata-system-test to main October 16, 2026 17:03
Forward OpenFeature evaluation details and validate serial IDs with dd-trace 6.18.0.

Environment: Datadog workspace

Co-Authored-By: Codex GPT-5 <noreply@localhost>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants