Repository navigation
Enable serial ID flag metadata tests for Node.js - #7852
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoOct 16, 2026
Merged
Conversation
Contributor
|
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🔗 Commit SHA: 7d614be | Docs | View more details | Give us feedback! |
hhan2024
force-pushed
the
ffe-serial-id-metadata-system-test
branch
from
September 30, 2026 16:24
9547cef to
ea6ec3f
Compare
hhan2024
requested review from
typotter and
vjfridge
and removed request for
a team
September 30, 2026 16:24
nccatoni
approved these changes
Oct 8, 2026
nccatoni
left a comment
Collaborator
There was a problem hiding this comment.
Looks like there is a merge conflict with utils/pytest.py otherwise LGTM. You should also get a review from someone familiar whit the feature
typotter
approved these changes
Oct 9, 2026
typotter
left a comment
Contributor
There was a problem hiding this comment.
lgtm pending merge conflicts
hhan2024
force-pushed
the
ffe-serial-id-metadata-system-test
branch
from
October 15, 2026 17:12
b59cca6 to
4352704
Compare
Forward OpenFeature evaluation details and validate serial IDs with dd-trace 6.18.0. Environment: Datadog workspace Co-Authored-By: Codex GPT-5 <noreply@localhost>
hhan2024
force-pushed
the
ffe-nodejs-serial-id-metadata
branch
from
October 16, 2026 18:09
fc1f59b to
7d614be
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
ffe-nodejs-serial-id-metadata
branch
October 16, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Uses the shared serial-ID tests merged in #7820.
The released Node.js SDK already exposes __dd_split_serial_id, so no SDK implementation change is needed.
Validation
./format.sh --checkpassed.Command: TEST_LIBRARY=nodejs ./run.sh PARAMETRIC --skip-parametric-build tests/parametric/test_ffe/test_serial_id_metadata.py tests/parametric/test_ffe/test_dynamic_evaluation.py