[hhan2024]

Go's parametric FFE adapter discarded OpenFeature flag metadata, so the serial-ID tests failed before they could inspect the SDK's behavior. Forward FlagMetadata unchanged and enable the tests for Go v2.10.1 and later.

Go already exposes the UFC split serial ID under dd.serialId; the shared test now checks that native key for Go while retaining __dd_split_serial_id for other SDKs. No Go SDK change is required. With span enrichment enabled, the tests verify positive and zero IDs, omission for missing IDs, targeting, and repeated evaluations.

Stacked on #7820 (ffe-serial-id-metadata-system-test).

Validation: all five serial-ID system tests passed against Go 2.10.1 without -F; ./format.sh passed.

SDK implementation: https://github.com/DataDog/dd-trace-go/blob/v2.10.1/openfeature/evaluator.go#L105-L107

FFE reviewer selection

Reviewers: @leoromanovsky, @sameerank

Why: Flag evaluation on EVP — This PR adds system-test coverage for SDK evaluation metadata. Reviewers come from the matched pod.

_{🤖 Automated selection.}

Selection details

Initiative: project / flag-evaluation-evp

Why this match: This PR adds system-test coverage for SDK evaluation metadata. The Go parametric adapter now passes OpenFeature FlagMetadata through unchanged. The shared serial-ID test checks that the selected UFC split's serial ID shows up in flagMetadata when span enrichment is on: under dd.serialId for Go and __dd_split_serial_id for the other SDKs. The manifests turn these tests on for Go v2.10.1 and later. That matches the 'SDK evaluation metadata' scope of flag-evaluation-evp. It is not an onboarding diagnostic and has no bandit purpose. The catalog has no entries with supplemental_review enabled, so no additional review areas apply.

• @leoromanovsky — primary (flag-evaluation-evp): Matched pod member. Existing review coverage preserved.
• @sameerank — floating (flag-evaluation-evp): Coverage and knowledge sharing. Existing review coverage preserved.

The PR author was excluded. Existing reviewers and teams were preserved.

Debug or fix a problem

Workflow run · Bits Code session

• Wrong project or pod? Clarify this PR’s purpose, or correct the reviewer registry and publish the change. Sheet edits take effect after publication.
• Need another reviewer now? Request them in GitHub. This workflow only adds requests and keeps existing reviewers.
• Stuck beyond five minutes or failed? Inspect the run’s failed step and available Bits session. After fixing the cause, rerun the workflow with this PR URL and dry_run=false. Unchanged completed runs are skipped. If the receipt says needs_reconciliation or a write outcome is uncertain, ask the workflow owner to reconcile GitHub and the receipt before retrying; do not delete the lock blindly.
• Report a problem: Comment on the reviewer-routing skill PR with this PR URL, the workflow run link, and the expected initiative or reviewer correction.

Evidence and run details

✅ Complete — reviewer coverage verified. The workflow checked pending requests or submitted reviews on the evaluated head.

Generated asynchronously by the FFE reviewer-routing workflow.

Changed paths: utils/build/docker/golang/parametric/ffe.go, tests/parametric/test_ffe/test_serial_id_metadata.py, manifests/golang.yml

Evaluated head: 3aeeb486753c3cfc6ffdfc94fc12dcffa0582e88

Registry revision: revision:1946aa2a-530e-487a-84a7-83aff44a1089

Pinned skill source: d214cfc65ae154b97d39af5cf32caf48aaec9bf0

Instructions: workflow-injected snapshot (no plugin loaded)

Instruction snapshot SHA-256: f23b2a88c13c0da90e2dd58246a14f257af91e2195c555039bd555b52e6f3516

[github-actions]

CODEOWNERS have been resolved as:

manifests/cpp.yml                                                       @DataDog/system-tests-reviewers
manifests/dotnet.yml                                                    @DataDog/system-tests-reviewers
manifests/golang.yml                                                    @DataDog/system-tests-reviewers
manifests/java.yml                                                      @DataDog/system-tests-reviewers
manifests/nodejs.yml                                                    @DataDog/system-tests-reviewers
manifests/php.yml                                                       @DataDog/system-tests-reviewers
manifests/python.yml                                                    @DataDog/system-tests-reviewers
manifests/ruby.yml                                                      @DataDog/system-tests-reviewers
manifests/rust.yml                                                      @DataDog/system-tests-reviewers
tests/parametric/test_ffe/test_serial_id_metadata.py                    @DataDog/feature-flagging-and-experimentation-sdk
utils/build/docker/golang/parametric/ffe.go                             @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core

[datadog-prod-us1-6]

 

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3c13549 | Docs | View more details | Give us feedback!}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T15:19:55.800070Z	c7065a9	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7065a97f0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".