[vjfridge]

Description

An oversized targeting key must not change the flag result or discard the
evaluation when native IPC submission degrades its telemetry. Extend the
existing native-client and OpenFeature API-to-wire tests with a consented
identity larger than 5 MiB, immediately followed by a normal identity in the
same PHP request, before any explicit flush or reconnect.

Assert correct values, exact counts and retained evaluation dimensions;
require the oversized event to omit identity/context and the successor to
retain both. Check that omitted data does not reach the wire or diagnostics.
The input exceeds the native budget; it does not specify its exact boundary.

This owns the PHP integration case removed from
the shared harness repair.
Native transport boundary tests remain in libdatadog. PHP activation in
system-tests is separate.

Validation

• Both API-to-wire PHPTs passed on PHP 8.2.34 NTS, with this branch's PHP
  sources and the existing extension artifact built from the merged feature
  PR head (37e3d84a1). No extension rebuild was needed for these test changes.
• Negative control: shrinking the oversized identity to a normal-sized key
  in an isolated fixture makes both tests fail on retained wire data.
• git diff --check passed.

Reviewer checklist

• Test coverage seems ok.
• Appropriate labels assigned.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-22T21:37:43.901035Z	e380290	PR opened
🔒 Security Review	✅ Completed 2026-10-22T21:40:47.168466Z	e380290	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[datadog-datadog-prod-us1]

More details

The added assertions cover oversized identity/context omission while preserving evaluation dimensions and the following normal evaluation. Static review found no actionable defect; runtime behavior remains unverified because the installed PHP lacks ddtrace.

Was this helpful? React 👍 or 👎

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit e380290}

[datadog-datadog-prod-us1]

 

✨ Unblock PR with BitsAI

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 9 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Loader test on amd64 libc: [8.3, nts, amd64, true] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | merge-gate — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

DataDog/apm-reliability/dd-trace-php | php-app.amd64.DOA9: [public.ecr.aws/lts/ubuntu:22.04, linux/amd64, 8.3] — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 74.39% (+0.03%)

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e380290 | Docs | View more details | Give us feedback!}