Repository navigation
A temp to address the data loss due to a fundamental mismatch between synchronous signals and asynchronous effects - #965
Closed
litianningdatadog wants to merge 1 commit into
Closed
litianningdatadog wants to merge 1 commit into
litianningdatadog wants to merge 1 commit into
Conversation
litianningdatadog
marked this pull request as ready for review
December 12, 2025 17:20
litianningdatadog
force-pushed
the
tianning.li/async-cancellation-data-loss
branch
2 times, most recently
from
December 12, 2025 19:09
072c2d7 to
38dc5c1
Compare
… synchronous signals and asynchronous effects How It Works: The new shutdown sequence ensures messages are not lost by: 1. Cancelling TelemetryListener and awaiting HTTP server shutdown 2. Dropping TelemetryListener to close logs_tx channel 3. Cancelling LogsAgent and awaiting its completion (ensuring all logs are drained) 4. Sending tombstone event only after all messages are processed 5. Dropping event_bus_tx and waiting for tombstone to be processed
litianningdatadog
force-pushed
the
tianning.li/async-cancellation-data-loss
branch
from
December 12, 2025 20:30
38dc5c1 to
6618299
Compare
litianningdatadog
marked this pull request as draft
January 5, 2026 22:04
Contributor
|
closing this as stale. #1455 makes the same fix, it drains the logs agent before sending the tombstone. feel free to reopen if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temp to address the data loss due to a fundamental mismatch between synchronous signals and asynchronous effects
How It Works:
The new shutdown sequence ensures messages are not lost by:
====
Justification: instead of hoping async work completes in time, we now enforce the order:
Each await transforms an asynchronous cancellation into a synchronous completion guarantee.