Repository navigation
Conversation
For a git dependency, Cargo builds the rev commit and uses version only as a check. bottlecap is not published, so the field has no other use. Renovate reads the field as a git tag name and proposes the saluki tag 0.1.0 commit, which is older than the pinned rev. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow manifest changes preserve dependency revisions and build features, with no blocking issues identified.
No open issues 🎉
What changed in this PR
This PR adjusts Bottlecap’s Git dependency declarations to prevent Renovate from proposing tag-based downgrades while preserving the commits used by Cargo.
Changes:
- Removes
versionfromdatadog-protos,ddsketch-agent, andlibddwaf. - Keeps Git sources, pinned revisions, and feature settings unchanged.
| File | Description |
|---|---|
bottlecap/Cargo.toml |
Removes version constraints from three revision-pinned Git dependencies. |
Review effort: Balanced
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: ee657e9 | Docs | View more details | Give us feedback! |
Problem
Renovate, the bot that opens dependency PRs, opens downgrade PRs for the two saluki crates,
datadog-protosandddsketch-agent. Examples are #1351, #1363, #1398 and #1399. Each one moves the crates fromf863626(November 2025) back tocd6db96(November 2024).Cause
Three git dependencies in
bottlecap/Cargo.tomlhave bothversionandrev. Renovate readsversionas the name of a git tag. Saluki has a tag0.1.0, so Renovate proposes the commit of that tag. ddoghq/dd-source#148796 has the steps in Renovate's code.For Cargo,
versionon a git dependency does not select the code. Cargo builds therevcommit and usesversiononly to check the crate version at that commit. The other use of the field is publishing to crates.io, and bottlecap haspublish = false.This PR
Removes
versionfrom the three git dependencies that pin arev:datadog-protos,ddsketch-agentandlibddwaf. The other git dependencies, from serverless-components, already have noversion:dogstatsd,datadog-fips,datadog-agent-configanddatadog-agent-trace-sampler.Impact
rev, Renovate proposes the newest commit of the repository. The saluki downgrade PRs stop, and upgrade PRs can come in their place.libddwafcan also get upgrade PRs, which it does not get today. ddoghq/dd-source#148796 turns off Renovate for the two saluki crates in this repository.Testing
Steps
cargo metadata --locked --format-version 1inbottlecap/.git status.Result
cargo metadata --lockedCargo.lockI did not build bottlecap locally. CI builds it.
🤖 Generated with Claude Code