Repository navigation
[SVLS-9963] Temporarily pin datadog-opentelemetry to 0.5.2 - #1464
litianningdatadog wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
Newly added dependencies are missing from the CI-checked license inventory, and the broader dependency refresh lacks build and runtime validation.
No open issues 🎉
What changed in this PR
This PR adds a temporary compatibility guard for Bottlecap’s OpenTelemetry integration while an upstream replacement is validated.
Changes:
- Pin
datadog-opentelemetryto exactly0.5.2, preserving existing features. - Document the temporary compatibility guard.
- Refresh registry dependencies in the lockfile without changing git dependency revisions.
| File | Description |
|---|---|
bottlecap/Cargo.toml |
Adds the exact version pin and explanatory comment. |
bottlecap/Cargo.lock |
Refreshes registry dependencies while retaining datadog-opentelemetry 0.5.2. |
Review effort: Balanced
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf2c85a437
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ] | ||
|
|
||
| [[package]] | ||
| name = "zlib-rs" |
There was a problem hiding this comment.
The lockfile refresh adds zlib-rs as a resolved dependency of flate2, but bottlecap/LICENSE-3rdparty.csv is unchanged and contains no zlib-rs entry. The license-3rdparty workflow runs dd-rust-license-tool check, so the stale inventory will fail that required check and omit the new dependency's attribution; regenerate the inventory alongside the lockfile.
Useful? React with 👍 / 👎.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 952f303 | Docs | View more details | Give us feedback! |
cf2c85a to
952f303
Compare
|
datadog-opentelemetry 0.5.4 is already published which pins OpenTelemetry 0.32, so we probably don't need this PR (or we can change it to pin 0.5.4) |
Overview
Jira: https://datadoghq.atlassian.net/browse/SVLS-9963
datadog-opentelemetrydependency to exactly0.5.2, preserving the existing feature configuration.bottlecap/Cargo.lock. This refresh also updates other registry dependencies within existing manifest constraints; git dependency versions and revisions are unchanged.Background and scope
datadog-opentelemetry0.5.3 changed its public OpenTelemetry dependencies from 0.32 to 0.33 in a patch release, breaking Rust consumers such as the reporteddatadog-aws-lambdae2e clients. Version 0.5.3 has since been yanked; a compatible 0.5.x repair is being prepared in DataDog/dd-trace-rs#343.Bottlecap uses the crate’s unstable propagation APIs and context types, not its OpenTelemetry tracer initialization. Its existing lockfile already selected 0.5.2, and no Bottlecap failure was reproduced. This change is a precautionary temporary dependency guard, not the permanent upstream fix or a claim to fix a reproduced Bottlecap build failure.
Removing the temporary pin
Once an upstream compatible replacement is available, validate the Bottlecap build and trace-propagation behavior, restore the normal version requirement, remove the temporary comment, and refresh the lockfile.
Testing
git diff --checkpassed before commit.cargo tree --manifest-path bottlecap/Cargo.toml --locked --offline -i datadog-opentelemetry --depth 1passed: Bottlecap anddatadog-agent-configresolve to 0.5.2.cargo tree --manifest-path bottlecap/Cargo.toml --locked --offline -i opentelemetry --depth 1passed: OpenTelemetry 0.32.0 and SDK 0.32.1.