fix(claude-sync): skip only flow-test-sandbox memory, not all $TMPDIR projects - #531
Merged
Merged
Conversation
… projects #530 skipped every -private-var-folders-* project, but a session whose cwd was $TMPDIR itself (-private-var-folders-...-T) can hold real memory: two such projects here have 5 memory files, one edited 2026-09-21. Narrow both the chezmoi-add filter and the commit-time exclude to *-flow-test-sandbox-*, the mktemp name run-all.sh uses. Real dirs: 71 total, 11 skipped, both real TMPDIR projects kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Data-Wise
added a commit
that referenced
this pull request
Sep 23, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#530 skipped every
~/.claude/projects/-private-var-folders-*memory folder. That turned out to be too broad. A session whose working folder was$TMPDIRitself produces a project named-private-var-folders-…-T, and those can hold real memory. Two do on this machine, with 5 memory files between them, one edited 2026-09-21. Since #530, their future edits would no longer sync.chezmoi addfilter and the commit-time exclude both now match only*-flow-test-sandbox-*, themktempnametests/run-all.shuses (line 71:mktemp -d "${TMPDIR:-/tmp}/flow-test-sandbox.XXXXXX"). This also covers sandboxes created under/tmp.Tests
New
test_syncs_real_memory_of_tmpdir_rooted_project: a project named-private-var-folders-xn-abc-Tmust reach the remote. It failed against #530's pattern (9 of 10 passed) and passes now (✓ All tests passed: 10/10). The two earlier tests for skipping sandboxes use…-flow-test-sandbox-…names and still pass.On the real
~/.claude/projects: 71 memory folders, 11 skipped (all*-flow-test-sandbox-*). The two real folders (-private-var-folders-ks-…-T,-private-var-folders-xn-…-T) are kept. Their current contents are already in dotfilesfc776f6.Full suite
./tests/run-all.sh: 86 passed, 3 failed. The failures are the same 3 as on #529 and #530 (test-doctor,e2e-em-dispatcher,test-atlas-contract), and they fail ondevwithout this change too.🤖 Generated with Claude Code