Refactor spawn_blocking error propagation - #420
Conversation
* Reviewed all spawn_blocking calls in src/core/config.rs, src/core/users.rs, and src/interface/web.rs. * Replaced redundant .context wrappers with idiomatic .await?? where appropriate to preserve error chains. * Replaced match statements in Axum handlers with unwrap_or_else to ensure JoinErrors are propagated as anyhow::Errors with meaningful context rather than silently swallowed or transformed into generic strings. * Replaced .unwrap_or defaults on spawn_blocking joins with .unwrap_or_else and logged the JoinErrors to prevent silent cancellation/panic failures in verify_async and the telemetry loop.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Refactors
tokio::task::spawn_blockingcalls inserver_managerto ensure idiomatic error propagation, specifically ensuring thatJoinErrors are not lost, silently ignored, or stripped of their trace information, while removing useless.context()wrappings that don't add meaningful diagnostic value. Ensures strict adherence to workspace hygiene.PR created automatically by Jules for task 2157307521563393444 started by @Cylae